Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish plugin zips to maven repo #306

Closed
Tracked by #1916
prudhvigodithi opened this issue Apr 28, 2022 · 6 comments
Closed
Tracked by #1916

Publish plugin zips to maven repo #306

prudhvigodithi opened this issue Apr 28, 2022 · 6 comments
Assignees
Labels

Comments

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Apr 28, 2022

Description

With existing setup the plugin jars are only published to maven repo, but not the generated plugin zips.

Related META issue

opensearch-project/opensearch-build#1916

Current Behavior

Existing all maven publications target the jar files to publish to maven, but not the generated distribution zips.

Expected Behavior

Along with plugin jars, plugin zips should also be published to maven repo with right maven coordinates, so user can download these plugins using dependancy model.

Steps To Reproduce

  1. Run the gradle assemble task that outputs jar and zips.
  2. Using build setup the jars are published to local staging maven repo.
  3. Zip's are just added to distribution's folder during build runtime.
  4. Finally once build is done, just the jar files are added to local maven repo and updates to the manifest file, but not the zips.

Proposed solution

A custom gradle plugin solution that can create the publication task for the zips to get published to local staging maven repo with right maven coordinates.
Add/Configure the custom gradle plugin openseearch.pluginzip to the gradle project and test the generated plugin zip's to upload to local maven repo.
More details on how to use the Plugin:
https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip

@bbarani
Copy link
Member

bbarani commented May 11, 2022

@sean-zheng-amazon @ylwu-amzn Can you please make the necessary changes as listed on the document to support publishing your zips to Maven?

@ylwu-amzn
Copy link
Collaborator

@bbarani sure, should we this ready before 2.0 GA release ?

@sean-zheng-amazon
Copy link
Contributor

@ylwu-amzn looks like the team is targetting end of June to have this done. we should start planning the work for upcoming sprint.

@ylwu-amzn
Copy link
Collaborator

Sure, assigned to Xun @Zhangxunmt

@Zhangxunmt
Copy link
Collaborator

#343
PR is in review.

@Zhangxunmt
Copy link
Collaborator

PR merged. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants