Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MacOS Support #161

Closed
2 tasks
dblock opened this issue Oct 27, 2021 · 4 comments
Closed
2 tasks

Add MacOS Support #161

dblock opened this issue Oct 27, 2021 · 4 comments
Assignees
@joshuali925
Labels
macos

Comments

@dblock
Copy link
Member

dblock commented Oct 27, 2021

Coming from opensearch-project/opensearch-plugins#96, add MacOS (Darwin) support.

  • Passing CI on MacOS
  • Documentation
@dblock dblock added the macos label Oct 27, 2021
This was referenced Oct 27, 2021
Open
Open
@anirudha
Copy link
Collaborator

not applicable

@dblock
Copy link
Member Author

dblock commented Oct 30, 2021

Adding MacOS CI will ensure that the plugin actually works on MacOS, we can't assume that it works because it's theoretically portable.

@dblock dblock reopened this Oct 30, 2021
@derek-ho derek-ho mentioned this issue Oct 11, 2022
Merged
6 tasks
@derek-ho
Copy link
Collaborator

Waiting for one more review here: #1108. Then will merge and close this ticket

@derek-ho
Copy link
Collaborator

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuali925 joshuali925

Labels
macos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anirudha @dblock @derek-ho @joshuali925