Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Copying a table with hyphens from the Show Databases flyover does not add backquotes #1856

Open
engechas opened this issue Aug 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@engechas
Copy link

engechas commented Aug 2, 2024

What is the bug?
This bug is related to direct query.

The LogExplorer for data sources has an option to "View databases and tables". Clicking this button opens a flyover where the ..

can be copied. When the db has hyphens in the name, backquotes are added to make it valid SQL syntax.

Example:
Database with name my-db becomes <backquote>my-db<backquote> (backquote = `)

The same behavior is not seen for tables with hyphens in the name

Example:
Table with name my-table does not get backquotes added when copying

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Create a Glue table with hyphens in the name
  2. Go to the LogExplorer page for a data source
  3. Open the "View databases and tables" flyover
  4. Copy the ..
from the button in the flyover
  • Paste the copied value to see no backquotes around the table name
  • What is the expected behavior?
    Table names with hyphens should be backquoted the same way database names with hyphens are

    What is your host/environment?

    • Version: 2.13

    Do you have any screenshots?
    image

    Do you have any additional context?
    Add any other context about the problem.

    @engechas engechas added bug Something isn't working untriaged labels Aug 2, 2024
    @dblock dblock removed the untriaged label Aug 26, 2024
    @dblock
    Copy link
    Member

    dblock commented Aug 26, 2024

    [Catch All Triage - 1, 2, 3, 4, 5]

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    bug Something isn't working
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants