Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can OpenSearch-Build make sure it does not create a breaking change for external workflows? #1536

Closed
3 tasks
Tracked by #1234
peternied opened this issue Jan 24, 2022 · 3 comments
Closed
3 tasks
Tracked by #1234
Labels
enhancement New Enhancement

Comments

@peternied
Copy link
Member

peternied commented Jan 24, 2022

As the workflow scripts are not located in the same repository, there need to be protections to be sure that these workflows are not broken when changes are made.

Having a list of all registered component repositories, a way to find all of the workflows, and then execute them to verify they have not regressed would be a way to do this.

Acceptance Criteria:

  • Determine the relationship between OpenSearch-Build and test repositories
    • OpenSearch-Build has a library of tools, make sure client workflows have access as well as are checked to verify that have not been broken by an interface change. This seems to be a set of regression tests with all libraries included
  • How will checks be run during pull requests to make sure that workflows in other repositories are not broken?
  • What happens if someone breaks the workflow on their side, is there an inverse check to make sure aren't out of alignment with the central repository?
@gaiksaya
Copy link
Member

gaiksaya commented Aug 5, 2022

One approach to avoid breaking change is my keeping regressions files in build repository and jenkins Files in component repository. In this way when a change is introduced, the regression files will test the change for remote JenkinsFiles as well.
Failure would suggest a change needs to be made on remote file as well

@gaiksaya
Copy link
Member

#1534 (comment)

@gaiksaya
Copy link
Member

Versioning is the way to go forward. If anyone has something better please let us know. Created an issue to track this during implementation #2489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants