Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded git repo checkout for the repo opensearch-build #1901

Closed
tianleh opened this issue Apr 4, 2022 · 5 comments · Fixed by #2038
Closed

Remove hardcoded git repo checkout for the repo opensearch-build #1901

tianleh opened this issue Apr 4, 2022 · 5 comments · Fixed by #2038
Assignees
Labels
feature New feature

Comments

@tianleh
Copy link
Member

tianleh commented Apr 4, 2022

We have noticed a few places where the build repo link is hardcoded for checkout. E.g
https://github.com/opensearch-project/opensearch-build/blob/ff40ffba5e96836eaf8a3d70f0b4444bf6d2ef2b/vars/buildDockerImage.groovy

https://github.com/opensearch-project/opensearch-build/blob/9a82a23231cfa6f07bc4fa677b43795fbe8f49ff/vars/detectDockerAgent.groovy

Developers need to modify these values to their folked repo name and branch which is lowering the development efficient. These values shall read from the local workspace or as params.

@tianleh
Copy link
Member Author

tianleh commented Apr 4, 2022

cc @peterzhuamazon

@peterzhuamazon peterzhuamazon added the untriaged Issues that have not yet been triaged label Apr 4, 2022
@abhinavGupta16
Copy link
Contributor

[triage] We can take in the repository url and the branch as parameters and default to main if not provided for places where we checkout opensearch-build within libraries.

@abhinavGupta16 abhinavGupta16 added feature New feature and removed untriaged Issues that have not yet been triaged labels Apr 5, 2022
@peterzhuamazon peterzhuamazon changed the title Remove hardcoded repo checkout for the repo opensearch-build Remove hardcoded git repo checkout for the repo opensearch-build Apr 21, 2022
@peterzhuamazon
Copy link
Member

Apparently jenkins would pull git repo when pulling the jenkinsfile, so we can delete these git url calls once we confirm not needing them anymore.

Thanks.

@peterzhuamazon
Copy link
Member

This is nearly done except @zelinh whitesource scan, but that one is ok as it does not need to specify other versions.
@zelinh can decide whether want to change it or not.

Thanks.

@peterzhuamazon
Copy link
Member

This is nearly done except @zelinh whitesource scan, but that one is ok as it does not need to specify other versions. @zelinh can decide whether want to change it or not.

Thanks.

I have sent an PR to update here:
#2038

@peterzhuamazon peterzhuamazon linked a pull request Apr 26, 2022 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants