-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded git repo checkout for the repo opensearch-build
#1901
Labels
feature
New feature
Comments
[triage] We can take in the repository url and the branch as parameters and default to main if not provided for places where we checkout |
abhinavGupta16
added
feature
New feature
and removed
untriaged
Issues that have not yet been triaged
labels
Apr 5, 2022
peterzhuamazon
changed the title
Remove hardcoded repo checkout for the repo
Remove hardcoded git repo checkout for the repo Apr 21, 2022
opensearch-build
opensearch-build
Apparently jenkins would pull git repo when pulling the jenkinsfile, so we can delete these git url calls once we confirm not needing them anymore. Thanks. |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have noticed a few places where the build repo link is hardcoded for checkout. E.g
https://github.com/opensearch-project/opensearch-build/blob/ff40ffba5e96836eaf8a3d70f0b4444bf6d2ef2b/vars/buildDockerImage.groovy
https://github.com/opensearch-project/opensearch-build/blob/9a82a23231cfa6f07bc4fa677b43795fbe8f49ff/vars/detectDockerAgent.groovy
Developers need to modify these values to their folked repo name and branch which is lowering the development efficient. These values shall read from the local workspace or as params.
The text was updated successfully, but these errors were encountered: