Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Retrospective] Release version 2.0.0 (RC1) #2046

Closed
peternied opened this issue Apr 27, 2022 · 16 comments
Closed

[Retrospective] Release version 2.0.0 (RC1) #2046

peternied opened this issue Apr 27, 2022 · 16 comments

Comments

@peternied
Copy link
Member

How to use this issue?
Please add comments to this issue, they can be small or large in scope. Honest feedback is important to improve our processes, suggestions are also welcomed but not required.

What will happen to this issue post release?
There will be a discussion(s) about how the release went and how the next release can be improved. Then this ticket will be updated with the notes of that discussion along side action items.

@peternied
Copy link
Member Author

Security had trouble getting the proper 2.0.0 build for a while, we thought we had done what was needed for the transport client removal, but ended up having to revisit it several times. I'm not sure mechanically what wasn't working (getting the correct build, change propagation delays)

@peternied
Copy link
Member Author

It doesn't look like component issues are being used to track release status, see several issues that do not yet have preparation phases complete (this is a sampling of them)

Is there a new process?

@peternied
Copy link
Member Author

Build qualifier switch from 2.0.0-alpha1 -> 2.0.0-rc1 was hard to track

@dblock
Copy link
Member

dblock commented Apr 27, 2022

Is there a new process?

No new process, just nobody ran after plugin owners this time around.

@peternied
Copy link
Member Author

The release issue is unreadable with the description being so long and test reports hard to find relevant information to the state of the release.

@bbarani
Copy link
Member

bbarani commented May 3, 2022

How could we have found the issue on the website drop down before day of launch? CC: @CEHENKLE

@peterzhuamazon
Copy link
Member

@anirudha @praveensameneni @bbarani
Let us discuss about managing both OS and OSD plugins within the same repo.

Tagging notificationsDashboards at eb3af31759668a94727950d081e8a3a161f22918 ...
Tagging notifications-core at 482337090e9707e3e00c3538166bc62b45308d28 ...

As we can see OS 2695 use a different commit from notifications than OSD 3015 also in notifications, to build OS and OSD notifications plugins respectively.

This would cause potential discrepancies between OS and OSD build going on.

We need to discuss how to properly manage these plugins and their repos.

Thanks.

@peternied
Copy link
Member Author

Some teams created release tags for rc1, isn't clear what should or should be done as part of post release steps in the component or centralized release issue.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 3, 2022

Some teams created release tags for rc1, isn't clear what should or should be done as part of post release steps in the component or centralized release issue.

No team is creating tags for rc1, it is already automated from infra side.

  • Edit: I just notice security team has a github action to create tags.
    I am not sure why that is the case as the tag is already automated from Infra side.
    Thanks.

@dblock
Copy link
Member

dblock commented May 4, 2022

Some teams created release tags for rc1, isn't clear what should or should be done as part of post release steps in the component or centralized release issue.

No team is creating tags for rc1, it is already automated from infra side.

  • Edit: I just notice security team has a github action to create tags.
    I am not sure why that is the case as the tag is already automated from Infra side.
    Thanks.

Open an issue to delete it.

@kavilla
Copy link
Member

kavilla commented May 9, 2022

It seems like there is expectation for OpenSearch Dashboards (+ plugins) to be prepped and sanity tested complete when OpenSearch (+ plugins) completes. That seems to be broken to me, for minor releases it is achievable, but for major releases it's shouldn't be expected. If any sanity tests found that OpenSearch was invalid then any result during OpenSearch Dashboards should be considered invalid. If we don't, and find out the regression occurs in OpenSearch but then we not spent multiple resources on OpenSearch Dashboards and OpenSearch.

I think for all major releases the RC1 for OpenSearch should be cut and sanity test complete and any regression is fixed prior to the OpenSearch Dashboards beginning it's release cycle (or at least ensure that the release cycle deadlines are not the same). If OpenSearch (+ plugins) needs to check in a bug fix the Friday before release then we should factor that and add buffer time for OpenSearch Dashboards (+ plugins) to react.

@kavilla
Copy link
Member

kavilla commented May 9, 2022

Release notes should not be in the code complete section until after sanity tests are complete. I see multiple repos checking this check box off when anything could happen during sanity testing that requires them to make a change and update their release notes. Release notes can be in draft but I think there should be buffer room to ensure that release notes are the last things that checked off to ensure the accuracy of the notes.

@kavilla
Copy link
Member

kavilla commented May 9, 2022

Build qualifier switch from 2.0.0-alpha1 -> 2.0.0-rc1 was hard to track

I think this was a big miss. I think we prioritized getting an alpha1 build of OpenSearch green which caused a lot of last minute changes to get an rc1 build. OpenSearch plugins needs an rc1 build to switch build no rc1 build existed so then it was a chicken and egg problem which then ended up making the Friday before the week of the initial planned released being the first day an OpenSearch 2.0.0-rc1 build was actually made. Giving initially a few days of sanity tests for OpenSearch and virtually none for OpenSearch Dashboards.

@peternied
Copy link
Member Author

Distribution build breaks were happening constantly, it was hard to know if the build was passing or not. The slack channel #opensearch-distribution-builds seems like it was unmonitored.

@peterzhuamazon
Copy link
Member

Close this one and leads to 2.0.0 GA in #2142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants