Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bundle manifest not defined correctly #252

Closed
setiah opened this issue Aug 17, 2021 · 1 comment
Closed

[BUG] Bundle manifest not defined correctly #252

setiah opened this issue Aug 17, 2021 · 1 comment
Assignees
Labels
beta Issues specific to the OpenSearch Beta bug Something isn't working untriaged Issues that have not yet been triaged

Comments

@setiah
Copy link
Contributor

setiah commented Aug 17, 2021

Describe the bug
The expected syntax for bundle manifest file is #111 . The test infra expects a bunch of parameters which are missing in the manifest file and because of that it breaks.

Traceback (most recent call last):
  File "python/test.py", line 17, in <module>
    manifest = BundleManifest.from_file(args.manifest)
  File "/home/ubuntu/cicd/opensearch-build/bundle-workflow/python/manifests/bundle_manifest.py", line 29, in from_file
    return BundleManifest(yaml.safe_load(file))
  File "/home/ubuntu/cicd/opensearch-build/bundle-workflow/python/manifests/bundle_manifest.py", line 35, in __init__
    self.build = self.Build(data['build'])
  File "/home/ubuntu/cicd/opensearch-build/bundle-workflow/python/manifests/bundle_manifest.py", line 51, in __init__
    self.architecture = data['architecture']
KeyError: 'architecture'

Reproduce
Run the test.py from main branch of opensearch-build repo

~/opensearch-build/bundle-workflow$ python python/test.py --manifest /home/ubuntu/cicd/opensearch-build/manifests/opensearch-1.0.0.yml

@setiah setiah added bug Something isn't working untriaged Issues that have not yet been triaged beta Issues specific to the OpenSearch Beta labels Aug 17, 2021
@camerski
Copy link
Contributor

camerski commented Aug 18, 2021

@setiah You have confused bundle and input manifests. The manifest you're looking at is an input manifest (consumed by build.py). test.py reads a bundle manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Issues specific to the OpenSearch Beta bug Something isn't working untriaged Issues that have not yet been triaged
Projects
None yet
Development

No branches or pull requests

3 participants