Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK-20 builds on Jenkins #3425

Assignees
Labels
cicd docker enhancement New Enhancement jenkins Jenkins related issue

Comments

@reta
Copy link
Contributor

reta commented Apr 19, 2023

Is your feature request related to a problem? Please describe

JDK-19 is superseded by JDK-20

Describe the solution you'd like

Make JDK-20 available on Jenkins so we could start using it in Gradle checks.

Describe alternatives you've considered

N/A

Additional context

Depends on opensearch-project/OpenSearch#6792

@reta reta added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Apr 19, 2023
@reta
Copy link
Contributor Author

reta commented Apr 19, 2023

@peterzhuamazon I wil pick this one up if you don't mind

@rishabh6788 rishabh6788 removed the untriaged Issues that have not yet been triaged label Apr 25, 2023
@peterzhuamazon
Copy link
Member

Hi @reta are we ok to wait until JDK21 release?
JDK21 is LTS and it will be released on September.
Thanks.

@reta
Copy link
Contributor Author

reta commented Apr 29, 2023

Hi @reta are we ok to wait until JDK21 release?

I think we could in general, but we need to:

  • update bundled JDK to JDK-20 (we cannot supply unsupported version)
  • make sure all test passes under JDK-20

I will update the issue shortly if the JDK-20 is really needed on CI, thanks!

@reta
Copy link
Contributor Author

reta commented May 1, 2023

@peterzhuamazon I just did test run against JDK-20 and it seems like we do have some code paths that use unsupported APIs (like Thread::resume, at least in tests), I think it would be beneficial to add JDK-20 support to CI and be ready for JDK-21

@peterzhuamazon
Copy link
Member

So @reta we need to ship JDK20 in bundle right now?

@peterzhuamazon
Copy link
Member

Please also send a PR to change JDK on opensearch-ci so we can do the deployment of new AMIs.

@reta
Copy link
Contributor Author

reta commented May 5, 2023

So @reta we need to ship JDK20 in bundle right now?

I think it would be better to do it now, since it does require code changes sadly

@peterzhuamazon
Copy link
Member

peterzhuamazon commented May 5, 2023

Hi,

I will work with @reta on this.
Once @reta inform that core switch 3.0.0 to 20, this change will go in then.

Thanks.

@peterzhuamazon
Copy link
Member

After offline conversation seems like we have to build the image beforehand so the test of this PR can pass:
opensearch-project/OpenSearch#7344

Will start that on next week.

Thanks.

@peterzhuamazon peterzhuamazon added cicd docker jenkins Jenkins related issue labels May 19, 2023
@github-actions github-actions bot added the untriaged Issues that have not yet been triaged label May 19, 2023
@peterzhuamazon peterzhuamazon removed the untriaged Issues that have not yet been triaged label May 19, 2023
@reta
Copy link
Contributor Author

reta commented May 19, 2023

@peterzhuamazon confirming successful Jenkins builds (Gradle check) [1]:

Using an external service to test the repository-s3 plugin
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.1.1
  OS Info               : Linux 5.15.0-1036-aws (amd64)
  JDK Version           : 20 (Eclipse Temurin JDK)
  JAVA_HOME             : /usr/lib/jvm/temurin-20-jdk-amd64
  Random Testing Seed   : 47DB33C7350F49DD
  In FIPS 140 mode      : false
=======================================

[1] https://build.ci.opensearch.org/job/gradle-check/15791/console

@peterzhuamazon
Copy link
Member

@peterzhuamazon confirming successful Jenkins builds (Gradle check) [1]:

Using an external service to test the repository-s3 plugin
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.1.1
  OS Info               : Linux 5.15.0-1036-aws (amd64)
  JDK Version           : 20 (Eclipse Temurin JDK)
  JAVA_HOME             : /usr/lib/jvm/temurin-20-jdk-amd64
  Random Testing Seed   : 47DB33C7350F49DD
  In FIPS 140 mode      : false
=======================================

[1] https://build.ci.opensearch.org/job/gradle-check/15791/console

Note this only applies to the gradle check as they are using AMI directly.
The build process still not onboard with images as the docker builds still ongoing.
Thanks.

@peterzhuamazon
Copy link
Member

All jdk20 docker images and amis updated now.
Thanks.

@peterzhuamazon
Copy link
Member

https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/7931/

We are missing the macos update to JDK20 and is really confused why Windows still shows issues not finding JDK20.
Need researching.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment