-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JDK-20 builds on Jenkins #3425
Support JDK-20 builds on Jenkins #3425
Comments
@peterzhuamazon I wil pick this one up if you don't mind |
Hi @reta are we ok to wait until JDK21 release? |
I think we could in general, but we need to:
I will update the issue shortly if the JDK-20 is really needed on CI, thanks! |
@peterzhuamazon I just did test run against JDK-20 and it seems like we do have some code paths that use unsupported APIs (like |
So @reta we need to ship JDK20 in bundle right now? |
Please also send a PR to change JDK on opensearch-ci so we can do the deployment of new AMIs. |
I think it would be better to do it now, since it does require code changes sadly |
After offline conversation seems like we have to build the image beforehand so the test of this PR can pass: Will start that on next week. Thanks. |
@peterzhuamazon confirming successful Jenkins builds (Gradle check) [1]:
[1] https://build.ci.opensearch.org/job/gradle-check/15791/console |
Note this only applies to the gradle check as they are using AMI directly. |
All jdk20 docker images and amis updated now. |
We are missing the macos update to JDK20 and is really confused why Windows still shows issues not finding JDK20. Thanks. |
Is your feature request related to a problem? Please describe
JDK-19 is superseded by JDK-20
Describe the solution you'd like
Make JDK-20 available on Jenkins so we could start using it in Gradle checks.
Describe alternatives you've considered
N/A
Additional context
Depends on opensearch-project/OpenSearch#6792
The text was updated successfully, but these errors were encountered: