[BUG] opensearch-2.12.0-linux-x64.rpm hangs on prein script

[guildin]

Describe the bug

opensearch package installation hangs while executing preinst script.

The following code in PREIN:

yum list installed opensearch

can't be used while executing yum install, because yum is already running and another instance of yum will be stucked like:

Another app is currently holding the yum lock; waiting for it to exit...
  The other application is: yum
    Memory :  91 M RSS (1.4 GB VSZ)
    Started: Thu Mar  7 13:04:21 2024 - 10:44 ago
    State  : Sleeping, pid: 31532

The following section:

if rpm -q opensearch >/dev/null 2>&1 || yum list installed opensearch >/dev/null 2>&1; then
    OPENSEARCH_ALREADY_INSTALLED="yes"
else
    OPENSEARCH_ALREADY_INSTALLED="no"
fi

can be refactored like:

%pre
...
if [ $1 -eq 1 ]; then
  #install
  OPENSEARCH_ALREADY_INSTALLED="no"
fi
if [ $1 -eq 2 ]; then
  #upgrade
  OPENSEARCH_ALREADY_INSTALLED="yes"
fi
...

rpm scriptlets reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/

Related component

Build

To Reproduce

yum install opensearch

Expected behavior

yum install opensearch able to complete installation

Additional Details

Host/Environment (please complete the following information):

• OS: CentOS
• Version 7.9.2009

[andrross]

[Triage - attendees 1 2 3]
@opensearch-project/triage Can you transfer this issue to https://github.com/opensearch-project/opensearch-build ?

[andrross]

The file in question is located here: https://github.com/opensearch-project/opensearch-build/blob/main/scripts/pkg/build_templates/opensearch/rpm/opensearch.rpm.spec

[bbarani]

Tagging @peterzhuamazon to take a look at this issue.

[peterzhuamazon]

This behavior does not happen on docker with systemd configured.
Tho it is something that will cause a conflict per logs, and confirmed on a full-ledge linux server.

Adding @DarshitChanpura @derek-ho to double check on this and potentially apply the suggested patch by @guildin.

Thanks!

[peterzhuamazon]

I will remove the prein script changes in rpm, just like deb, so that deb and rpm are consistent here. @DarshitChanpura @derek-ho
All the checking will be passed to the postin script so that demo install script in security repo taken care of the behavior.

Thanks.

[DarshitChanpura]

sounds good. I agree, let's keep it consistent.

[resetsa]

Please fix this for branch 1.x also