You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like my fix for #4569 was too aggressive, the fix is now over-escaping the url slashes and making it even harder to navigate...
Probably can fix it by adding / to the safe argument in quote_plus: urllib.parse.quote_plus(file, safe='/'). But I'm still not sure about the extra slash before cypress-screenshots in the URL.
To reproduce
Open any test manifest file with failing tests (example) and see the failing test link:
Example actual result: https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.14.0/7603/linux/x64/rpm/test-results/5851/integ-test/observabilityDashboards/with-security//cypress-screenshots%2Fplugins%2Fobservability-dashboards%2F6_notebooks.spec.js%2FTest+reporting+integration+if+plugin+installed+--+View+reports+homepage+from+context+menu+--+after+each+hook+%28failed%29.png
Expected behavior
Example expected result: https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.14.0/7603/linux/x64/rpm/test-results/5851/integ-test/observabilityDashboards/with-security/cypress-screenshots/plugins/observability-dashboards/6_notebooks.spec.js/Test+reporting+integration+if+plugin+installed+--+View+reports+homepage+from+context+menu+--+after+each+hook+%28failed%29.png
Screenshots
No response
Host / Environment
No response
Additional context
The original goal of #4569 (and I guess this issue too) is to make it possible to ctrl+click the test manifest URLs to quickly get logs and failure screenshots without too much manual fiddling.
Relevant log output
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
It looks like my fix for #4569 was too aggressive, the fix is now over-escaping the url slashes and making it even harder to navigate...
Probably can fix it by adding
/
to thesafe
argument inquote_plus
:urllib.parse.quote_plus(file, safe='/')
. But I'm still not sure about the extra slash beforecypress-screenshots
in the URL.To reproduce
Open any test manifest file with failing tests (example) and see the failing test link:
Example actual result:
https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.14.0/7603/linux/x64/rpm/test-results/5851/integ-test/observabilityDashboards/with-security//cypress-screenshots%2Fplugins%2Fobservability-dashboards%2F6_notebooks.spec.js%2FTest+reporting+integration+if+plugin+installed+--+View+reports+homepage+from+context+menu+--+after+each+hook+%28failed%29.png
Expected behavior
Example expected result:
https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.14.0/7603/linux/x64/rpm/test-results/5851/integ-test/observabilityDashboards/with-security/cypress-screenshots/plugins/observability-dashboards/6_notebooks.spec.js/Test+reporting+integration+if+plugin+installed+--+View+reports+homepage+from+context+menu+--+after+each+hook+%28failed%29.png
Screenshots
No response
Host / Environment
No response
Additional context
The original goal of #4569 (and I guess this issue too) is to make it possible to ctrl+click the test manifest URLs to quickly get logs and failure screenshots without too much manual fiddling.
Relevant log output
No response
The text was updated successfully, but these errors were encountered: