[Bug]: Reporting build missing chromium dependency

[joshuali925]

Describe the bug

dashboards-reports plugin uses chromium to generate reports, the binary should be included in the artifact like this:
https://github.com/opensearch-project/dashboards-reports/blob/main/.github/workflows/dashboards-reports-test-and-build-workflow.yml#L67-L91

But this part is missing in build.sh.

To reproduce

Run opensearch and dashboards, reporting does not work because chromium binary reportsDashboards/.chromium/headless_shell does not exist

[peternied]

What are the possible values of PLATFORM and ARCHITECTURE in build.sh?

PLATFORM can be:

• linux
• darwin
• windows

ARCHITECTURE can be:

• x64
• arm64

See example usage

[joshuali925]

will ARCHITECTURE be supplied?

[ -z "$ARCHITECTURE" ] && ARCHITECTURE=`uname -m`

this can also be x86_64, amd64, aarch64, ... but the case only accepts x64 and arm64

[peternied]

This is a better source of truth, here are the values that will be allowed by the build system

class BuildArgs:
    SUPPORTED_PLATFORMS = ["linux", "darwin", "windows"]
    SUPPORTED_ARCHITECTURES = [
        "x64",
        "arm64",
    ]
    ```
https://github.com/opensearch-project/opensearch-build/blob/main/src/build_workflow/build_args.py#L12-L17

[joshuali925]

I see, thanks. What should I do if some combinations are not supported by reporting yet? We currently do not have chromium builds for darwin-arm64 and windows-arm64.

btw this also doesn't seem right

[ -z "$PLATFORM" ] && PLATFORM=`uname -s` | awk '{print tolower($0)}'

i think it's trying to do PLATFORM=$(uname -s | awk '{print tolower($0)}')

[dblock]

I see, thanks. What should I do if some combinations are not supported by reporting yet? We currently do not have chromium builds for darwin-arm64 and windows-arm64.

Manifests support excluding platforms by limiting the platforms supported as in here. There's no support for restricting architectures, we probably want to extend that code to be able to write:

platforms:
   - windows:x64
   - darwin:arm64

Feel free to open an issue/PR :)

i think it's trying to do PLATFORM=$(uname -s | awk '{print tolower($0)}')

Please fix!