Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema] Update buckets type in metrics mappings #92

Closed
kavithacm opened this issue Nov 7, 2023 · 0 comments
Closed

[Schema] Update buckets type in metrics mappings #92

kavithacm opened this issue Nov 7, 2023 · 0 comments
Assignees
Labels
schema schema related issue

Comments

@kavithacm
Copy link

kavithacm commented Nov 7, 2023

Which domain protocol is relevant for this schema ?

The issue is to update buckets type to nested in the observability metrics mapping to enable PPL to search and aggregate the buckets fields across documents directly. This change would help eliminate the manual process of retrieving all documents and aggregating buckets respectively in the frontend. The change would be as below.

Old mapping:

"buckets" : {
          "properties" : {
            "count" : {
              "type" : "long"
            },
            "max" : {
              "type" : "float"
            },
            "min" : {
              "type" : "float"
            }
          }
        },

New Mapping:

"buckets" : {
          "type" : "nested",
          "properties" : {
            "count" : {
              "type" : "long"
            },
            "max" : {
              "type" : "float"
            },
            "min" : {
              "type" : "float"
            }
          }
        },

What is the schema resource ?
The schema file which needs to be updated - https://github.com/opensearch-project/opensearch-catalog/blob/main/schema/observability/metrics/metrics-1.0.0.mapping#L137-L152

@kavithacm kavithacm added schema schema related issue untriaged labels Nov 7, 2023
@kavithacm kavithacm changed the title [Schema] Update mappings for buckets in metrics histogram [Schema] Update buckets type in metrics mappings Nov 7, 2023
@YANG-DB YANG-DB removed the untriaged label Nov 17, 2023
@YANG-DB YANG-DB self-assigned this Nov 17, 2023
@YANG-DB YANG-DB closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema schema related issue
Projects
Status: No status
Development

No branches or pull requests

2 participants