Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] adminPassword is required for versions below than 2.12.0 #90

Closed
gaiksaya opened this issue Jan 5, 2024 · 0 comments · Fixed by #91
Closed

[BUG] adminPassword is required for versions below than 2.12.0 #90

gaiksaya opened this issue Jan 5, 2024 · 0 comments · Fixed by #91
Assignees
Labels
bug Something isn't working

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Jan 5, 2024

What is the bug?

In order to accomodate security plugin tool changes, #86 was added as a feature. However, the logic resolving 2.3.0 as greater than 2.12.0. Mathematically it is correct but semver-wise its wrong.

How can one reproduce the bug?

Clone the repo at the above PR commit and try deploying using below command:

npm run cdk ls -- --context securityDisabled=false \
--context minDistribution=false --context distributionUrl='https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz' \
--context cpuArch='x64' --context singleNodeCluster=false --context dataNodeCount=3 \
--context dashboardsUrl='https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.12.0/opensearch-dashboards-2.12.0-linux-x64.tar.gz' \
--context distVersion=2.3.0 --context serverAccessType=prefixList --context restrictServerAccessTo=pl-f8a64391 --context additionalConfig='{"cluster.name": "cdk"}' --context mlNodeCount=1 \
--context use50PercentHeap=true
No VPC-Id Provided, a new VPC will be created

Error:

~/opensearch-project/opensearch-cluster-cdk/lib/infra/infra-stack.ts:212
      throw new Error('adminPassword parameter is required to be set when security is enabled');
            ^
Error: adminPassword parameter is required to be set when security is enabled

What is the expected behavior?

It should not throw and error for versions less than 2.12.0

What is your host/environment?

Operating system, version.

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant