Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] can't sort on field when document of that field contains null. fixed in elasticsearch-java. #158

Closed
joelbolt35 opened this issue May 16, 2022 · 7 comments
Labels
bug Something isn't working untriaged

Comments

@joelbolt35
Copy link

What is the bug?
A full convo can be found here regarding the bug:
https://discuss.elastic.co/t/failure-with-sorts-and-new-co-elastic-clients-elasticsearch-java-client/291511/12

tl;dr: Sorting on a field where documents contain null breaks.

What is the expected behavior?
I am able to sort on a field where some documents contain NULL in those fields.

Elastic Searches Fix
https://github.com/elastic/elasticsearch-java/pull/68/files

@joelbolt35 joelbolt35 added bug Something isn't working untriaged labels May 16, 2022
@joelbolt35 joelbolt35 changed the title [BUG] [BUG] can't sort on field when document of that field contains null. fixed in elasticsearch-java. May 16, 2022
@dblock
Copy link
Member

dblock commented May 16, 2022

@joelbolt35 Please feel free to reimplement a fix in this project. If you do, please confirm that you're not copying from non-APLv2 elasticsearch-java.

@chibenwa
Copy link
Contributor

Hello there,

As a notice, on a migration effort for Apache James to OpenSearch, with the rest client 2.0.0 and OpenSearch 2.0.0 we encouter the issue...

https://github.com/Arsnael/james-project/blob/970ef4dce2f48f581376ace450dc5891f3f0ef7b/mailbox/opensearch/src/test/java/org/apache/james/mailbox/opensearch/ElasticSearchIntegrationTest.java#L426

@Arsnael
Copy link
Contributor

Arsnael commented Jun 16, 2022

Hi guys!

Tried to take a crack at it as mentioned by my friend above we encountered that issue too. I took an approach completely different from the fix from es so I don't think it should be an issue.

Cheers!

@Arsnael
Copy link
Contributor

Arsnael commented Jun 24, 2022

Thanks for merging it team! Just want to know when can we expect a next release of the client with the fix?

@dblock
Copy link
Member

dblock commented Jun 27, 2022

I believe we can close this with #169.

We usually release clients along with the server, cc: @CEHENKLE

@dblock dblock closed this as completed Jun 27, 2022
@Arsnael
Copy link
Contributor

Arsnael commented Jun 29, 2022

We usually release clients along with the server, cc: @CEHENKLE

@dblock No offense but I saw other clients, even the high level java one, having a 2.0.1 release along with the server already, but this one didn't follow up it seems (2.0.0 still being the latest). Should I be worried?

@dblock
Copy link
Member

dblock commented Jun 29, 2022

@Arsnael I think we didn't release 2.0.1 because it wasn't needed. The 2.0 release works with 2.0.1.

I do understand that you want this bug fix released. Maybe we should start doing this more methodically? Care to open an issue saying "Release v. Next" and say "I need bug fix XYZ" or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

4 participants