Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetActions: Add support to dynamically register actions #107

Closed
saratvemulapalli opened this issue Aug 26, 2022 · 3 comments · Fixed by opensearch-project/OpenSearch#6734

Comments

@saratvemulapalli
Copy link
Member

saratvemulapalli commented Aug 26, 2022

  • Dynamically register transport actions in ActionModule

Transport Actions in extensions are registered with ExtensionsManager via Proxy Actions. But eventually we need make ActionModule dynamic to help register/de-register with OpenSearch

@saratvemulapalli saratvemulapalli changed the title Dynamically register transport actions in ActionModule GetActions: Add support to dynamically register actions Aug 26, 2022
@saratvemulapalli saratvemulapalli removed their assignment Mar 6, 2023
@minalsha
Copy link
Collaborator

This is also needed in future for hot-swap, right?

@owaiskazi19
Copy link
Member

This is also needed in future for hot-swap, right?

Yes

@dbwiddis
Copy link
Member

Right now transport actions are registered in a map which is:

  • final
  • unmodifiable

Sarat's draft PR linked above removed the unmodifiable bit for that map. However, I'm going to approach this in #525 by just adding a second dynamic map, and integrate the transportAction(action) method to check both maps. Other than that the implementation will be similar to the draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants