Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Implement Get Detector for AnomalyDetector Extension #211

Closed
Tracked by #5224
owaiskazi19 opened this issue Nov 1, 2022 · 3 comments
Closed
Tracked by #5224

[META] Implement Get Detector for AnomalyDetector Extension #211

owaiskazi19 opened this issue Nov 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@owaiskazi19
Copy link
Member

owaiskazi19 commented Nov 1, 2022

Is your feature request related to a problem?

Since we have the first feature up here for creating a detector.
Old plugin APIs for Get Detector:

1. GET _plugins/_anomaly_detection/detectors/<detectorId>
2. GET _plugins/_anomaly_detection/detectors/<detectorId>?job=true

This issue addresses the 1st request as 2nd has dependency on Job Scheduler. Until we finish the integration of Job Scheduler with AD Extension we can't start working on 2nd.

The proposed API for Get Detector with extensibility:

GET _extensions/_anomaly_detection/detectors/<detectorId>

The next milestone is to implement an API to get the detector which has already been created. The feature can be broken down as below:

  1. Currently the detector id is not randomized and is a pure string in the response of create detector - [FEATURE] Randomized detector id for create/get detector #212
  2. Create a Rest Handler to add GET method for the detector. - [FEATURE] Create a Rest Handler to add GET method for the detector #213
  3. Implement the logic for searching the detector. - [FEATURE] Implement the logic for searching the detector #214
  4. Create the response for Get Detector similar to old plugin architecture response. - [FEATURE] Create Get detector response #215

What solution would you like?

A clear and concise description of what you want to happen.

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@owaiskazi19 owaiskazi19 added enhancement New feature or request untriaged labels Nov 1, 2022
@owaiskazi19 owaiskazi19 changed the title [FEATURE] Implement Get Detector for AnomalyDetector Extension [META] Implement Get Detector for AnomalyDetector Extension Nov 1, 2022
@dbwiddis
Copy link
Member

dbwiddis commented Nov 1, 2022

How are we tracking the job scheduler one? Separate meta issue for job scheduler integration, or should we list it here knowing we can't do it yet?

@owaiskazi19
Copy link
Member Author

owaiskazi19 commented Nov 1, 2022

How are we tracking the job scheduler one? Separate meta issue for job scheduler integration, or should we list it here knowing we can't do it yet?

That's a good point. I am thinking of creating an issue and adding such features which are dependent on Job Scheduler there. We can link this issue with the meta issue which @joshpalis will create for Job Scheduler.
Update: Created #216

@owaiskazi19
Copy link
Member Author

Covered this issue in #373 and #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants