Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test to use a file from another temp directory #5158

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix test to use a file from another temp directory #5158

merged 1 commit into from
Nov 8, 2022

Conversation

adnapibar
Copy link
Contributor

Signed-off-by: Rabi Panda adnapibar@gmail.com

Description

The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Issues Resolved

Resolves #5156

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar added :test Adding or fixing a test backport 1.x backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch backport 2.4 Backport to 2.4 branch skip-changelog labels Nov 8, 2022
@adnapibar adnapibar requested a review from mch2 November 8, 2022 22:13
@adnapibar adnapibar requested review from a team and reta as code owners November 8, 2022 22:13
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 9970617 into opensearch-project:main Nov 8, 2022
@mch2 mch2 added backport 2.4 Backport to 2.4 branch and removed backport 2.4 Backport to 2.4 branch labels Nov 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 9970617)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@adnapibar adnapibar added backport 1.x backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch and removed backport 1.x backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch labels Nov 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 9970617)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 9970617)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 9970617)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Poojita-Raj pushed a commit that referenced this pull request Nov 9, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 9970617)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@adnapibar adnapibar added backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch and removed backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch labels Nov 11, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5158-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9970617eb34599127865fe01574452d54c95dfee
# Push it to GitHub
git push --set-upstream origin backport/backport-5158-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5158-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-5158-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9970617eb34599127865fe01574452d54c95dfee
# Push it to GitHub
git push --set-upstream origin backport/backport-5158-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-5158-to-1.3.

adnapibar pushed a commit that referenced this pull request Nov 11, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
reta pushed a commit that referenced this pull request Nov 11, 2022
The test used an absolute path which is incorrect as it made a platform dependent assumption. This change fixes that.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 9970617)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.4 Backport to 2.4 branch skip-changelog :test Adding or fixing a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AnalysisTests.testParseWordListOutsideConfigDirError
3 participants