Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code cleanup] Clean up new code for breadcrumb updates #377

Open
kavilla opened this issue Feb 21, 2023 · 6 comments · May be fixed by #732
Open

[Code cleanup] Clean up new code for breadcrumb updates #377

kavilla opened this issue Feb 21, 2023 · 6 comments · May be fixed by #732
Assignees
@BigSamu
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed technical debt

Comments

@kavilla
Copy link
Member

kavilla commented Feb 21, 2023 •
edited
Loading

Arguably this can be cleaned up a little for the sake of readability and stability:
https://github.com/opensearch-project/oui/pull/131/files#r1043950226
https://github.com/opensearch-project/oui/pull/131/files#r1043973824

Please feel free to close this issue if no plan to fix.
@kavilla kavilla added the enhancement New feature or request label Feb 21, 2023
@kavilla kavilla mentioned this issue Feb 21, 2023
Merged
6 tasks
@kavilla kavilla changed the title [Code cleanup] Clean up mutable lets [Code cleanup] Clean up new code for breadcrumb upeatews Feb 21, 2023
@kavilla kavilla changed the title [Code cleanup] Clean up new code for breadcrumb upeatews [Code cleanup] Clean up new code for breadcrumb updates Feb 21, 2023
@abbyhu2000 abbyhu2000 added CCI College Contributor Initiative good first issue Good for newcomers help wanted Extra attention is needed and removed CCI College Contributor Initiative labels Apr 11, 2023
@AbhishekReddy1127 AbhishekReddy1127 linked a pull request Apr 24, 2023 that will close this issue
Draft
6 tasks
@seanneumann seanneumann moved this to Todo in Look & Feel May 19, 2023
@joshuarrrr
Copy link
Member

@BSFishy Can we close this, or are there still action items here?

@BigSamu
Copy link
Contributor

BigSamu commented Oct 9, 2023

@BSFishy, @joshuarrrr do you need help on this issue? I can take a look at it if necessary. Or it is already solved?

@BSFishy
Copy link
Contributor

BSFishy commented Oct 9, 2023

do you need help on this issue? I can take a look at it if necessary. Or it is already solved?

It looks like #732 took a crack at it, but didn't finish. So you can take this one, if you're interested

@BigSamu
Copy link
Contributor

BigSamu commented Oct 10, 2023

OK, you can give me it. I will start looking it!

@BigSamu
Copy link
Contributor

BigSamu commented Nov 1, 2023

@joshuarrrr @BSFishy taking a look at this issue now. Sorry for the delay.

@BigSamu BigSamu mentioned this issue Nov 5, 2023
Merged
7 tasks
@BigSamu
Copy link
Contributor

BigSamu commented Nov 5, 2023

@joshuarrrr, @BSFishy PR #1144 was recently created to address this issue. Looking forward to your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BigSamu BigSamu

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed technical debt
Projects
Look & Feel
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code clean up for breadcrumbs update AbhishekReddy1127/oui
6 participants
@joshuarrrr @BSFishy @kavilla @BigSamu @abbyhu2000 @AbhishekReddy1127