Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] yarn lint is failing #41

Closed
bandinib-amzn opened this issue Aug 22, 2022 · 1 comment · Fixed by #42
Closed

[BUG] yarn lint is failing #41

bandinib-amzn opened this issue Aug 22, 2022 · 1 comment · Fixed by #42
Assignees
Labels
bug Something isn't working

Comments

@bandinib-amzn
Copy link
Member

bandinib-amzn commented Aug 22, 2022

Describe the bug
yarn lint is failing with following error:

$ yarn lint
yarn run v1.22.19
$ yarn tsc --noEmit && yarn lint-es && yarn lint-sass
$ /home/ubuntu/OSD/oui/node_modules/.bin/tsc --noEmit
$ eslint --cache "{src,src-docs}/**/*.{ts,tsx,js}" --max-warnings 0

/home/ubuntu/OSD/oui/src/components/icon/icon.test.tsx
  34:21  error  Unable to resolve path to module 'cheerio'  import/no-unresolved

✖ 1 problem (1 error, 0 warnings)

Because of failed yarn-lint, I'm not able to commit the changes.

To Reproduce
Steps to reproduce the behavior:
Run yarn lint

Expected behavior
yarn lint should be successful.

OpenSearch Version
N/A

Dashboards Version
N/A

Plugins

N/A

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@bandinib-amzn bandinib-amzn added the bug Something isn't working label Aug 22, 2022
@AMoo-Miki
Copy link
Collaborator

Check Cheerio:

  • rc.7 and rc.8 have issues with the folder structure in the release packages.
  • rc.6 causes a single test to fail by not matching the snapshot where the top values are off by 100px.
  • rc.5 passes all the tests and tolerates the overridden nested dependencies.

@AMoo-Miki AMoo-Miki mentioned this issue Aug 22, 2022
6 tasks
@KrooshalUX KrooshalUX moved this to Icebox (No Dev) in OUI Components Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants