Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OuiHeader background to use the same value as OuiPageBackgroundColor #901

Closed
Tracked by #895
KrooshalUX opened this issue Jul 20, 2023 · 3 comments · Fixed by #936
Closed
Tracked by #895

Update OuiHeader background to use the same value as OuiPageBackgroundColor #901

KrooshalUX opened this issue Jul 20, 2023 · 3 comments · Fixed by #936
Assignees

Comments

@KrooshalUX
Copy link
Contributor

No description provided.

@joshuarrrr
Copy link
Member

joshuarrrr commented Jul 20, 2023

@KrooshalUX Currently the OuiHeader takes a theme prop which can be set to dark, and there's a different background color defined in that case:

Screen.Recording.2023-07-20.at.4.20.48.PM.mov

// Themeable colors
$ouiHeaderBackgroundColor: $ouiColorEmptyShade !default;
$ouiHeaderDarkBackgroundColor: lightOrDarkTheme(shade($ouiColorDarkestShade, 28%), shade($ouiColorLightestShade, 50%)) !default;
$ouiHeaderBorderColor: $ouiBorderColor !default;
$ouiHeaderBreadcrumbColor: $ouiColorDarkestShade !default;

So what should we do for when the dark header prop is set (in both light and dark site themes?)

@joshuarrrr
Copy link
Member

The actual values:

Next dark:

 "ouiHeaderBackgroundColor": "#0a121a",
  "ouiHeaderDarkBackgroundColor": "#0d1720",

Next:

"ouiHeaderBackgroundColor": "#fcfeff",
  "ouiHeaderDarkBackgroundColor": "#212e3a",

@joshuarrrr joshuarrrr self-assigned this Jul 20, 2023
@KrooshalUX
Copy link
Contributor Author

"So what should we do for when the dark header prop is set (in both light and dark site themes?)" - good question.

The idea behind using the background page color as the navigation background color is to help the page content "pop" and give a lighter, less chrome-heavy feeling to the application (there is more to do in this regard, like perhaps removing the bottom border, but thats TBD after seeing the result of this change IRL).

So, in that lens - my overall concern is regarding the defaults - less so decisions the dashboards customer/builder may have chosen (ex: dark mode navigation in a light mode interface). I imagine deprecating this at this phase will cause unexpected chaos, so for users/customers/builders who have manually set this, if they are using light mode but set the header to dark mode, it wont have the same appearance effect, but at least it would reflect the correct color (vs what appears to be a much darker color than I intended).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants