Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Replace checked in reports-scheduler/src/test/resources/job-scheduler/opensearch-job-scheduler-1.2.3.0-*.zip with a dynamic dependency #263

Closed
Tracked by #1375 ...
dblock opened this issue Dec 18, 2021 · 3 comments · Fixed by #337

Comments

@dblock
Copy link
Member

dblock commented Dec 18, 2021

Describe the bug

When we increment a version we also need to update job-scheduler by hand.

cd job-scheduler
git checkout 1.2
git pull
./gradlew assemble

rm ../dashboards-reports/reports-scheduler/src/test/resources/job-scheduler/*
cp ./build/distributions/opensearch-job-scheduler-1.2.3.0-SNAPSHOT.zip ../dashboards-reports/reports-scheduler/src/test/resources/job-scheduler/

This random version of job-scheduler built on my machine is not reliable and will hide bugs.

Expected behavior
This shouldn't be needed, replace with a dynamic dependency.

@zhongnansu
Copy link
Member

note: to whoever takes this task

reference from job-scheduler README: Add this workaround to make sure that job-schedular plugin is correctly installed during integration tests.

@dblock
Copy link
Member Author

dblock commented Jan 3, 2022

We have to deal with this in every release? How can we get this prioritized?

@zhongnansu zhongnansu removed the Beta label Jan 5, 2022
@zhongnansu zhongnansu self-assigned this Mar 1, 2022
@zhongnansu zhongnansu added infra and removed bug Something isn't working labels Mar 1, 2022
@dblock
Copy link
Member Author

dblock commented Mar 14, 2022

Here's a full list:

./dashboards-reports/reports-scheduler/src/test/resources/bwc/job-scheduler/1.13.0.0/opendistro-job-scheduler-1.13.0.0.zip
./dashboards-reports/reports-scheduler/src/test/resources/bwc/job-scheduler/1.3.0.0-SNAPSHOT/opensearch-job-scheduler-1.3.0.0-SNAPSHOT.zip
./dashboards-reports/reports-scheduler/src/test/resources/bwc/reports-scheduler/1.13.0.0/opendistro-reports-scheduler-1.13.0.0.zip
./dashboards-reports/reports-scheduler/src/test/resources/job-scheduler/opensearch-job-scheduler-1.3.0.0-SNAPSHOT.zip

This is now a child of opensearch-project/opensearch-build#1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants