Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Personalize ranking processor from being created as part of an ad hoc pipeline #182

Closed
msfroh opened this issue Jul 25, 2023 · 2 comments
Assignees
Labels
enhancement change or upgrade that increases software capabilities beyond original client specifications

Comments

@msfroh
Copy link
Collaborator

msfroh commented Jul 25, 2023

In opensearch-project/OpenSearch#8163, we made a change to pass the pipeline creation context to a processor factory, so the factory can take appropriate action depending on how it's being called.

For the Personalize ranking processor, we should fail if invoked as part of a search request (i.e. in an ad hoc pipeline), to make sure that we're not creating a new AWS Personalize client on every search request. This requires a check in the Personalize processor factory.

@msfroh msfroh added enhancement change or upgrade that increases software capabilities beyond original client specifications untriaged labels Jul 25, 2023
@noCharger
Copy link
Collaborator

We will create the new release candidate 2.9.0.1 for this fix.

@msfroh msfroh self-assigned this Jul 25, 2023
@msfroh msfroh moved this from 🆕 New to 🏗 In progress in Search Project Board Jul 25, 2023
@msfroh msfroh removed the untriaged label Jul 25, 2023
@noCharger noCharger moved this from 🏗 In progress to 👀 In review in Search Project Board Jul 26, 2023
@mingshl
Copy link
Collaborator

mingshl commented Jul 28, 2023

updated the artifact link here

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Search Project Board Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement change or upgrade that increases software capabilities beyond original client specifications
Projects
Archived in project
Development

No branches or pull requests

3 participants