You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the recent refactor of the security REST APIs introduced in #3123 a regression was made that changed the behavior of how the PATCH API to update roles mappings worked.
Before the PR was merged the PATCH API was able to perform operations on static roles.
The reason this was not caught is because there currently is no unit test to assert the behavior of the PATCH API to update roles mappings on a static role. There should be a unit test to assert the intended behavior.
The text was updated successfully, but these errors were encountered:
cwperks
added
bug
Something isn't working
untriaged
Require the attention of the repository maintainers and may need to be prioritized
labels
Aug 31, 2023
As described this is a functional test scenario, why do you think this should be a unit test?
peternied
removed
the
untriaged
Require the attention of the repository maintainers and may need to be prioritized
label
Aug 31, 2023
cwperks
changed the title
[BUG] Add a unit test to ensure that using PATCH API to update Roles Mappings works on a static role
[BUG] Add a test to ensure that using PATCH API to update Roles Mappings works on a static role
Aug 31, 2023
@peternied We have such tests in RolesMappingApiTest but they cover only hidden roles verification not reserved and statics both for PUT and PATCH as result it is not clear from tests how it should work.
With the recent refactor of the security REST APIs introduced in #3123 a regression was made that changed the behavior of how the PATCH API to update roles mappings worked.
Before the PR was merged the PATCH API was able to perform operations on
static
roles.After the PR was merged the PATCH API started failing with the following error:
The reason this was not caught is because there currently is no unit test to assert the behavior of the PATCH API to update roles mappings on a static role. There should be a unit test to assert the intended behavior.
The text was updated successfully, but these errors were encountered: