Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if TransportPassiveAuthSetting can be safely removed #3448

Closed
2 tasks
cwperks opened this issue Oct 3, 2023 · 3 comments
Closed
2 tasks

Determine if TransportPassiveAuthSetting can be safely removed #3448

cwperks opened this issue Oct 3, 2023 · 3 comments
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@cwperks
Copy link
Member

cwperks commented Oct 3, 2023 •
edited
Loading

I found another instance related to Transport auth in the security plugin that looks like its a contender for removal. TransportPassiveAuthSetting appears to be related to Transport-layer authentication which was removed with the TransportClient in #1701.

Acceptance Criteria:

  • Determine if TransportPassiveAuthSetting is safe to remove
  • If it is safe to remove, open a PR and remove it
@cwperks cwperks added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Oct 3, 2023
@stephen-crawford
Copy link
Contributor

stephen-crawford commented Oct 9, 2023 •
edited
Loading

[Triage] Hi @cwperks, feel free to open a PR to this point. Or please amend the closure criteria to include something that can be executed through a PR.

@stephen-crawford stephen-crawford removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label Oct 9, 2023
@cwperks cwperks added the triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. label Oct 23, 2023
@cwperks
Copy link
Member Author

cwperks commented Jan 4, 2024

Closing this issue, this setting is transient and applicable when performing a rolling upgrade of a cluster where security is disabled to a cluster where security is enabled. #1156

@cwperks cwperks closed this as completed Jan 4, 2024
@peternied
Copy link
Member

@cwperks Is there anything we should do to make it clearer that it is important? Do you remember what caused you to think it should be deleted in the first place on inspection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peternied @cwperks @stephen-crawford