Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Leftover references to Elasticsearch #24

Open
dblock opened this issue Oct 12, 2022 · 3 comments
Open

[BUG] Leftover references to Elasticsearch #24

dblock opened this issue Oct 12, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented Oct 12, 2022

What is the bug?

We have a ton of Elasticsearch references in code, https://github.com/opensearch-project/spring-data-opensearch/search?q=Elasticsearch. What's the plan to deprecate those in favor of OpenSearch?

What is the expected behavior?

All "elasticsearch" becomes "opensearch".

@dblock dblock added the bug Something isn't working label Oct 12, 2022
@reta
Copy link
Collaborator

reta commented Oct 18, 2022

@dblock large chunk of them is expectable: we do rely on Spring Data Elasticsearch and as such, many classes / inrteraces / beans contain Elasticsearch in their names, no much we can do about it sadly (but there could be some leftovers indeed).

@dblock
Copy link
Member Author

dblock commented Oct 19, 2022

Can our own code, such as this package, move from org.springframework.data.elasticsearch.core to an 'opensearch' namespace?

@reta
Copy link
Collaborator

reta commented Oct 19, 2022

Can our own code, such as this package, move from org.springframework.data.elasticsearch.core to an 'opensearch' namespace?

The org.springframework.data.elasticsearch.core (under test only) is 1:1 copy of the spring-data-elasticsearch test scaffolding, technically we can move it under our own package, I have mentioned it here #1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants