-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Field and Fields Parameters in Relevance Search Functions #1067
Validate Field and Fields Parameters in Relevance Search Functions #1067
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #1067 +/- ##
============================================
- Coverage 98.30% 95.81% -2.50%
- Complexity 3518 3530 +12
============================================
Files 342 352 +10
Lines 8694 9376 +682
Branches 554 679 +125
============================================
+ Hits 8547 8984 +437
- Misses 142 334 +192
- Partials 5 58 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
db89bbd
9f5304c
to
a79dfcd
Compare
@forestmvey can you make sure that we aren't reducing coverage with this PR? |
7e08c83
to
8fa4d22
Compare
Signed-off-by: forestmvey <forestv@bitquilltech.com>
8fa4d22
to
f9aa20e
Compare
sql/src/main/java/org/opensearch/sql/sql/parser/AstExpressionBuilder.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes!
…1067) (#1199) Change relevance functions that query fields to throw a SemanticCheckException when a field is queried that does not exist. Signed-off-by: forestmvey <forestv@bitquilltech.com> (cherry picked from commit d03c176) Co-authored-by: Forest Vey <36905077+forestmvey@users.noreply.github.com>
Description
Relevance functions that query fields should act similar to how a
SELECT
query works. If a field is queried that does not exist, aSemanticCheckException
should be thrown.Example Queryies
SELECT * FROM stackexchange_beer WHERE query_string([invalid], 'beer');
SELECT * FROM stackexchange_beer WHERE match(invalid, 'beer');
Issues Resolved
Issue: 613
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.