Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add TIMEDIFF and DATEDIFF functions. (#131) #1234

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 438c44d from #1195

* Add `TIMEDIFF` and `DATEDIFF` functions.

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Max Ksyunz <maxk@bitquilltech.com>

Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Max Ksyunz <maxk@bitquilltech.com>
(cherry picked from commit 438c44d)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 6, 2023 17:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #1234 (438c44d) into 2.x (de79815) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 438c44d differs from pull request most recent head f0ae82c. Consider uploading reports for the commit f0ae82c to get more accurate results

@@            Coverage Diff            @@
##                2.x    #1234   +/-   ##
=========================================
  Coverage     98.32%   98.33%           
- Complexity     3555     3575   +20     
=========================================
  Files           346      344    -2     
  Lines          8768     8819   +51     
  Branches        554      559    +5     
=========================================
+ Hits           8621     8672   +51     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...expression/function/RelevanceFunctionResolver.java 100.00% <ø> (ø)
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprDateValue.java 100.00% <100.00%> (ø)
...g/opensearch/sql/data/model/ExprDatetimeValue.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <100.00%> (ø)
.../opensearch/sql/data/model/ExprTimestampValue.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/data/model/ExprValueUtils.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <100.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen merged commit 9d7a6eb into 2.x Jan 6, 2023
@github-actions github-actions bot deleted the backport/backport-1195-to-2.x branch January 6, 2023 18:38
@dai-chen dai-chen added the enhancement New feature or request label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants