Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] InteractiveHandler should invalidate the session if the REPL session's lastUpdateTime is outdated #2415

Closed
penghuo opened this issue Nov 3, 2023 · 1 comment
Labels
bug Something isn't working Flint v2.12.0 Issues targeting release v2.12.0

Comments

@penghuo
Copy link
Collaborator

penghuo commented Nov 3, 2023

what is the issue

  • Index is temporary not available.
  • REPL job fetch request from index, got 503 error.
  • REPL job can not update sessionState from running to fail.
  • InteractiveHandler can still submit job because the sessionState still running.

proposed solution

  • InteractiveHandler check lastUpdateTime before every query submission.
  • if session is state, cleanUp session.
  • create new session for the request.
@kaituo
Copy link
Contributor

kaituo commented Dec 6, 2023

fixed in #2448 (review)

@penghuo penghuo closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Flint v2.12.0 Issues targeting release v2.12.0
Projects
None yet
Development

No branches or pull requests

3 participants