Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-anonymized queries can be added to OpenSearch logs #821

Closed
MaxKsyunz opened this issue Sep 12, 2022 · 2 comments
Closed

[BUG] Non-anonymized queries can be added to OpenSearch logs #821

MaxKsyunz opened this issue Sep 12, 2022 · 2 comments
Labels
bug Something isn't working legacy Issues related to legacy query engine to be deprecated

Comments

@MaxKsyunz
Copy link
Collaborator

MaxKsyunz commented Sep 12, 2022

QueryDataAnonymizer fails to anonymize queries that are only supported by the v2 engine.

When that happens, the query including parameter values is added to OpenSearch log.

Root Cause

QueryDataAnonymizer uses v1 parser to determine what elements in the AST need to be anonymized. When a query fails v1 engine, anonymization is skipped and the query is logged as-is.

@MaxKsyunz MaxKsyunz added untriaged legacy Issues related to legacy query engine to be deprecated labels Sep 12, 2022
@MaxKsyunz
Copy link
Collaborator Author

Relates to #787

@Yury-Fridlyand
Copy link
Collaborator

Completed via #1665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working legacy Issues related to legacy query engine to be deprecated
Projects
None yet
Development

No branches or pull requests

3 participants