Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change trigger when functionRepository created #944

Closed
Yury-Fridlyand opened this issue Oct 20, 2022 · 2 comments
Closed

[FEATURE] Change trigger when functionRepository created #944

Yury-Fridlyand opened this issue Oct 20, 2022 · 2 comments
Labels
maintenance Improves code quality, but not the product

Comments

@Yury-Fridlyand
Copy link
Collaborator

Is your feature request related to a problem?

functionRepository created on execution of the each query. For the first query on the current server run this creates a significant lag in ~3-5 seconds regardless of query complexity. The delay grows along with amount of functions implemented.

What solution would you like?

N/A

What alternatives have you considered?

N/A

Do you have any additional context?

The task is to define another trigger when SQL plugin should build the repository.

  • Do it once
  • Decide when to do
    • on init?
    • in background after init?
  • When and how to re-init a repository (consider a new function repository added/updated in runtime)
@Yury-Fridlyand Yury-Fridlyand added the enhancement New feature or request label Oct 20, 2022
@dai-chen dai-chen added maintenance Improves code quality, but not the product and removed enhancement New feature or request labels Oct 28, 2022
@dai-chen
Copy link
Collaborator

It may be helpful that we avoided creating Spring container per request in #822. On the safe side, it was merged to maximus-m1 feature branch. If no issue, it will be merged to 2.x in future. Thanks!

@dai-chen
Copy link
Collaborator

Changes in #822 is already merged to main and 2.x branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Development

No branches or pull requests

2 participants