Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Simplify Explain execution plan and Response listener abstraction #985

Open
penghuo opened this issue Oct 28, 2022 · 1 comment
Open

[Enhancement] Simplify Explain execution plan and Response listener abstraction #985

penghuo opened this issue Oct 28, 2022 · 1 comment
Assignees
@penghuo
Labels
maintenance Improves code quality, but not the product Priority-Low

Comments

@penghuo
Copy link
Collaborator

penghuo commented Oct 28, 2022

Problem Statements

  1. AbstractPlan has seperate interface for execute() and explain() which should be simplified to execute() only.
  2. ExplainResponse and QueryResponse should be unified as QueryResponse.
@penghuo penghuo added enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Oct 28, 2022
@penghuo
Copy link
Collaborator Author

penghuo commented Oct 28, 2022 •
edited
Loading

Related to #845

@penghuo penghuo mentioned this issue Oct 28, 2022
Merged
6 tasks
@dai-chen dai-chen added maintenance Improves code quality, but not the product and removed enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Oct 28, 2022
@dai-chen dai-chen changed the title [Enhancement] Simpliy Explian execution plan and Response listener abstraction [Enhancement] Simplify Explain execution plan and Response listener abstraction Dec 14, 2022
@dai-chen dai-chen added the v2.5.0 'Issues and PRs related to version v2.5.0' label Dec 14, 2022
@dai-chen dai-chen removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@penghuo penghuo

Labels
maintenance Improves code quality, but not the product Priority-Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@penghuo @dai-chen @acarbonetto