Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate to aws-sdk-go-v2 #151

Open
jmaitrehenry opened this issue Jan 23, 2024 · 1 comment
Open

[FEATURE] Migrate to aws-sdk-go-v2 #151

jmaitrehenry opened this issue Jan 23, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jmaitrehenry
Copy link

Is your feature request related to a problem?

Actually, the aws-dsk-go is deprecated.
Also, it contain security issue actually because of one of the dependency is not updated, so we could try to update the aws-sdk to fix the dependency or we could try to migrate to the new SDK.

What solution would you like?

I think, migrating to the new SDK is more futur proof, but, it require go 1.19 and this project use go 1.18.
I don't know if it could be an issue to migrate to a newer version of go in the same time.

What alternatives have you considered?

Updating the current AWS SDK or inform the AWS SDK team of the issue.

Do you have any additional context?

Actually, I found the problem here: https://github.com/opensearch-project/terraform-provider-opensearch/pull/150/checks?check_run_id=20781305950

And the dependency issue come from golang.org/x/net@v0.17.0 which is required by github.com/aws/aws-sdk-go@v1.50.1

❯ go mod graph | grep golang.org/x/crypto@v0.14
golang.org/x/net@v0.17.0 golang.org/x/crypto@v0.14.0

❯ go mod graph | grep golang.org/x/net@v0.17.0
github.com/aws/aws-sdk-go@v1.50.1 golang.org/x/net@v0.17.0
@prudhvigodithi
Copy link
Collaborator

[Triage]
Thanks @jmaitrehenry, can you please take a look and to see for upgrading to go 1.19 ?
Thanks
Adding @bbarani @rblcoder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants