Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

OSM CLI prompt to upgrade #2294

Closed
ritazh opened this issue Jan 13, 2021 · 9 comments
Closed

OSM CLI prompt to upgrade #2294

ritazh opened this issue Jan 13, 2021 · 9 comments
Assignees
Labels
kind/needed priority/P1 P1 priority size/M 7 days (~1.5 week) stale

Comments

@ritazh
Copy link
Contributor

ritazh commented Jan 13, 2021

Please describe the Improvement and/or Feature Request

OSM CLI should have a way to detect its own version compared to the installed chart version and prompt user to upgrade the CLI.

Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [X ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • CI System [ ]
  • Project Release [ ]

Possible use cases

@draychev
Copy link
Contributor

From my shell scripts - I use this to get the latest release for certain automation tasks:

curl --silent "https://api.github.com/repos/openservicemesh/osm/releases/latest" | grep -Po '"tag_name": "\K.*?(?=")'

The Go version of this in the OSM CLI would be great.

The second step would be to compare the latest available with what's running in the Kubernetes cluster.

  • we could get that from the Deployment spec: kubectl get deployment -n osm-system osm-controller -o json | jq '.spec.template.spec.containers[0].image'
  • or the running OSM Controller itself (logs or debug endpoint)

@mudit-01
Copy link
Contributor

I can work on it pls assign it to me

@github-actions
Copy link

Added default label kind/needed. Please consider re-labeling this issue appropriately.

@steeling steeling added priority/P1 P1 priority and removed priority/P2 P2 priority labels Jul 15, 2022
@trstringer trstringer modified the milestones: vFuture, v1.3 Jul 19, 2022
@mudit-01
Copy link
Contributor

mudit-01 commented Aug 4, 2022

Hi pls assign it to me.

@keithmattix keithmattix modified the milestones: v1.3, vFuture Sep 7, 2022
@trstringer trstringer removed this from the vFuture milestone Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update.

@github-actions github-actions bot added the stale label Feb 1, 2023
@mudit-01
Copy link
Contributor

mudit-01 commented Feb 1, 2023

can be fixed by #5266

@github-actions github-actions bot removed the stale label Feb 2, 2023
@mudit-01
Copy link
Contributor

We can close this now fixed by #5266

@github-actions
Copy link

This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update.

@github-actions github-actions bot added the stale label May 15, 2023
@github-actions
Copy link

Issue closed due to inactivity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/needed priority/P1 P1 priority size/M 7 days (~1.5 week) stale
Projects
Status: Done
Development

No branches or pull requests

8 participants