Make bookstore app ports configurable in automated demo

[ksubrmnn]

Make demo app ports configurable. This will help users customize the demos to suit their environments.

[addozhang]

+1, 80 is not acceptable in openshift.

[allenlsy]

Are we talking about configuring the port forwarding port in auto demo? I think they are configurable now.

E.g. https://github.com/openservicemesh/osm/blob/main/scripts/port-forward-bookstore-ui.sh#L18

Or do I misunderstand the issue?

[ksubrmnn]

This issue is for this port (for all the demo apps):

osm/docs/example/manifests/apps/bookstore-v2.yaml

Line 11 in 94fc23d

- port: 14001

[draychev]

This GitHub Issue would also provide great value in instrumenting end-to-end tests where we can randomize app ports (within some ranges).
This will ensure that we are not accidentally hard-coding ports in Envoy configs etc.

[shashankram]

This GitHub Issue would also provide great value in instrumenting end-to-end tests where we can randomize app ports (within some ranges).
This will ensure that we are not accidentally hard-coding ports in Envoy configs etc.

The bookstore apps are not used in e2e tests, we use a combination of curl and httpbin. I agree some sort of fuzzing around the values used in e2e tests is valuable, but I don't see a benefit to complicating the existing bookstore demo apps to perform this sort of fuzz testing. Moreover, the automated demo (run-osm-demo.sh) is already getting complicated with the number of permutations being introduced.

@draychev Do you think this is still necessary?

[draychev]

@shashankram This does not seem too critical.
@allenlsy If you already have a PR for this change (I understand this to be the case) - I would not be opposed to merging it.

[allenlsy]

PR reopened. PTAL.

#3619

[allenlsy]

Feature is not needed any more as we want to keep our demo application simple.