Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Update SMI policy's status field w/ errors #3218

Closed
1 task
draychev opened this issue Apr 22, 2021 · 2 comments
Closed
1 task

Update SMI policy's status field w/ errors #3218

draychev opened this issue Apr 22, 2021 · 2 comments
Labels
area/debugging Debug & Troubleshooting tooling area/SMI SMI implementation related

Comments

@draychev
Copy link
Contributor

draychev commented Apr 22, 2021

Would it make sense to update the status field of an SMI policy with a message of some kind when things are not ok?

apiVersion: access.smi-spec.io/v1alpha3
metadata:
  name: podinfo-access
kind: TrafficTarget
spec:
  destination:
    kind: ServiceAccount
    name: podinfo
  rules:
  - kind: HTTPRouteGroup
    matches:
    - everything
    name: podinfo-http-routes
  sources:
  - kind: ServiceAccount
    name: podinfo

# ----------------------------

status:
  errors: 
    - HTTPRouteGroup podinfo-http-routes does not exist in namespaces default

Related

@draychev draychev changed the title Update SMI policy's status field w/ errors OSM may have found Update SMI policy's status field w/ errors OSM Controller may have found Apr 22, 2021
@draychev draychev changed the title Update SMI policy's status field w/ errors OSM Controller may have found Update SMI policy's status field w/ errors Apr 23, 2021
@michelleN
Copy link
Contributor

Yes! There is not a status field on the APIs at the moment so we'd need to add that in the SMI sdk first.

@draychev draychev added the area/SMI SMI implementation related label May 12, 2021
@draychev draychev added this to the v0.10.0 milestone May 21, 2021
@draychev draychev added the area/debugging Debug & Troubleshooting tooling label Jun 22, 2021
@draychev draychev removed this from the v0.10.0 milestone Jun 28, 2021
@snehachhabria
Copy link
Contributor

This is a change would be needed in SMI, closing the issue here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/debugging Debug & Troubleshooting tooling area/SMI SMI implementation related
Projects
None yet
Development

No branches or pull requests

4 participants