Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

test: pkg/certificate/providers/tresor/certificate_manager.go functions #3439

Closed
SanyaKochhar opened this issue May 25, 2021 · 0 comments · Fixed by #3564
Closed

test: pkg/certificate/providers/tresor/certificate_manager.go functions #3439

SanyaKochhar opened this issue May 25, 2021 · 0 comments · Fixed by #3564
Labels
area/tests Related to tests size/XS 1 day
Milestone
v0.10.0

Comments

@SanyaKochhar
Copy link
Contributor

SanyaKochhar commented May 25, 2021 •
edited
Loading

In pkg/certificate/providers/tresor/certificate_manager.go, the unit test coverage can be improved for the following functions:

  • GetCertificate()
  • RotateCertificate()
  • IssueCertificate()
  • issue()

See highlighted lines below.

image

image

image

image

ref #1489
@SanyaKochhar SanyaKochhar added size/XS 1 day area/tests Related to tests labels May 25, 2021
@SanyaKochhar SanyaKochhar added this to the v0.10.0 milestone May 25, 2021
@SanyaKochhar SanyaKochhar changed the title test: pkg/certificate/providers/tresor/certificate_manager.go GetCertificate failure case test: pkg/certificate/providers/tresor/certificate_manager.go functions May 26, 2021
This was referenced May 26, 2021
Closed
Closed
Closed
@shuheiktgw shuheiktgw mentioned this issue Jun 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/tests Related to tests size/XS 1 day
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

tests(pkg/certificate/providers/tresor): add missing tests shuheiktgw/osm
1 participant
@SanyaKochhar