Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Migrate from ptypes.MarshalAny to a deterministic MarshalAny function to stabilize tests #878

Closed
draychev opened this issue Jun 23, 2020 · 2 comments
Closed

Migrate from ptypes.MarshalAny to a deterministic MarshalAny function to stabilize tests #878

draychev opened this issue Jun 23, 2020 · 2 comments
Labels
area/tests Related to tests good first issue Good for newcomers priority/P3 P3 priority size/M 7 days (~1.5 week)
Milestone
v0.10.0

Comments

@draychev
Copy link
Contributor

The current MarshalAny() function we use results in non-deterministic output, which causes test failures.
Even though it may cost in CPU cycles, it would be great to implement a deterministic Marshal function.
Github has great examples on this: https://github.com/search?q=MarshalAnyDeterministic&type=Code
@SanyaKochhar SanyaKochhar added area/tests Related to tests priority/P3 P3 priority and removed post-MVP labels Aug 24, 2020
@SanyaKochhar
Copy link
Contributor

@eduser25 are you working on this issue?

@draychev draychev mentioned this issue Jan 26, 2021
Closed
@draychev draychev added the size/M 7 days (~1.5 week) label Jan 26, 2021
@draychev draychev added this to the v0.10.0 milestone May 25, 2021
@draychev draychev mentioned this issue Jun 30, 2021
Closed
15 tasks
@draychev draychev closed this as completed Jul 6, 2021
@draychev
Copy link
Contributor Author

draychev commented Jul 6, 2021

no longer needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/tests Related to tests good first issue Good for newcomers priority/P3 P3 priority size/M 7 days (~1.5 week)
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
3 participants
@eduser25 @SanyaKochhar @draychev