Skip to content

Commit c41b3b6

Browse files
enhance review-changes with repository conventions and context-aware analysis │
│ │ │ - Add repository convention checks (AGENTS.md, CONTRIBUTING.md compliance) │ │ - Expand performance analysis beyond web/TypeScript focus │ │ - Add distributed systems, microservices, and database-specific reviews │ │ - Include additional language support (Rust, improved Go/Python) │ │ - Ensure context-aware analysis for different system architectures
1 parent 723c7a1 commit c41b3b6

File tree

1 file changed

+53
-23
lines changed

1 file changed

+53
-23
lines changed

plugins/git/commands/review-changes.md

Lines changed: 53 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -41,28 +41,36 @@ The command analyzes git changes using multiple review perspectives:
4141
- `--commits N`: `git diff HEAD~N..HEAD` (last N commits)
4242
2. Extract changed files and diff content
4343
3. Identify file types for language-specific analysis
44+
4. Check for repository conventions (AGENTS.md, CONTRIBUTING.md, etc.)
4445

4546
**Step 2: Multi-Perspective Analysis**
4647
Analyze changes from these perspectives:
47-
1. **Security Review**
48+
1. **Repository Conventions Review**
49+
- Check adherence to AGENTS.md guidelines (if present)
50+
- Validate plugin structure and naming conventions
51+
- Review commit message format compliance
52+
- Ensure ethical guidelines are followed (no real person references)
53+
54+
2. **Security Review**
4855
- Check for hardcoded secrets/credentials
4956
- Identify potential injection vulnerabilities
5057
- Review authentication/authorization changes
5158
- Flag unsafe file operations
5259

53-
2. **Performance Review**
54-
- Identify inefficient algorithms or data structures
55-
- Check for unnecessary database queries
56-
- Review memory allocation patterns
57-
- Flag potential bottlenecks
60+
3. **Performance Review** (context-aware)
61+
- Web/Frontend: Bundle size, render performance, API calls
62+
- Distributed Systems: Consensus algorithms, network partitions, eventual consistency
63+
- Microservices: Circuit breakers, retry patterns, service boundaries
64+
- Database: Query efficiency, indexing, transaction boundaries
65+
- General: Memory allocation, algorithm complexity
5866

59-
3. **Code Quality Review**
67+
4. **Code Quality Review**
6068
- Assess code readability and maintainability
6169
- Check adherence to established patterns
6270
- Review error handling implementation
6371
- Validate naming conventions
6472

65-
4. **Testing Coverage**
73+
5. **Testing Coverage**
6674
- Identify untested code paths
6775
- Suggest test cases for new functionality
6876
- Review existing test modifications
@@ -177,31 +185,53 @@ git add src/auth.ts src/middleware.ts
177185
- Suggests secure alternatives for identified issues
178186
- Focuses on defensive security practices only
179187

180-
## Language-Specific Reviews
188+
## Context-Aware Analysis
189+
190+
**Web/Frontend Systems:**
191+
- Bundle size optimization and lazy loading
192+
- React/Vue component lifecycle issues
193+
- DOM manipulation efficiency
194+
- Browser compatibility concerns
195+
196+
**Distributed/Microservice Systems:**
197+
- CAP theorem considerations (Consistency, Availability, Partition tolerance)
198+
- Service mesh configuration and circuit breakers
199+
- Event sourcing and saga patterns
200+
- Distributed transaction handling
201+
- Network partition resilience
202+
203+
**Database Systems:**
204+
- ACID property maintenance
205+
- Query optimization and indexing strategies
206+
- Connection pooling and resource management
207+
- Migration safety and rollback procedures
208+
209+
**Language-Specific Reviews:**
181210

182211
**TypeScript/JavaScript:**
183-
- ESLint rule violations
184-
- TypeScript strict mode compliance
185-
- React/Node.js best practices
212+
- ESLint rule violations and TypeScript strict mode
213+
- Async/await patterns and Promise handling
186214
- Package vulnerability checks
187215

188216
**Python:**
189-
- PEP 8 style compliance
217+
- PEP 8 compliance and type hint coverage
190218
- Security best practices (bandit-style checks)
191-
- Performance anti-patterns
192-
- Type hint coverage
219+
- Concurrent programming patterns
193220

194221
**Go:**
195-
- Go fmt compliance
196-
- Race condition detection
197-
- Error handling patterns
198-
- Interface design review
222+
- Go fmt compliance and race condition detection
223+
- Goroutine lifecycle management
224+
- Interface design and error handling patterns
225+
226+
**Rust:**
227+
- Ownership and borrowing correctness
228+
- Memory safety and performance patterns
229+
- Cargo.toml dependency management
199230

200231
**General:**
201-
- Documentation completeness
202-
- Git commit message quality
203-
- Breaking change identification
204-
- Backward compatibility analysis
232+
- Repository convention adherence (AGENTS.md, CONTRIBUTING.md)
233+
- Documentation completeness and accuracy
234+
- Breaking change identification and migration paths
205235

206236
## Arguments
207237

0 commit comments

Comments
 (0)