Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disableRoute=true seems not to work #2533

Open
brunoNetId opened this issue Mar 1, 2024 · 2 comments
Open

disableRoute=true seems not to work #2533

brunoNetId opened this issue Mar 1, 2024 · 2 comments

Comments

@brunoNetId
Copy link

When a Service is created with the annotation disableRoute, it seems the flag is ignored and the route is created anyway

Here's the annotation definition I'm using:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  annotations:
    ...
    serving.knative.openshift.io/disableRoute: 'true'
@dsimansk
Copy link
Contributor

dsimansk commented Mar 1, 2024

The annotation is part of e2e testsuite here:

// 1. Create Kservice with disableRoute annotation.
// 2. Verify operator did not create OpenShift Route.

Can you pls share what version of Serverless operator are you using, and OpenShift version at least?

Also a networking layer being used here. I'm not sure if that works outside of Kourier actually.

@skonto
Copy link
Contributor

skonto commented May 15, 2024

@brunoNetId gentle ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants