Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch leader if MCO is going to reboot a node #392

Closed
cgwalters opened this issue Jul 15, 2020 · 2 comments
Closed

switch leader if MCO is going to reboot a node #392

cgwalters opened this issue Jul 15, 2020 · 2 comments

Comments

@cgwalters
Copy link
Member

Moving this from openshift/machine-config-operator#1897 (comment)

I am an etcd/raft novice, but it would seem to make sense to me for the MCO and CEO to communicate and for the CEO to notice the MCO is in the process of draining/rebooting a node and to be sure that the node being upgraded at least isn't the leader.

Detecting "node will be upgraded" could be implemented today in CEO by watching the currentConfig and desiredConfig annotations - if they are different that's what the MCO will react to.

Alternatively, the MCD could explicitly notice the case when it's on a control plane node and signal etcd directly.
@cgwalters cgwalters mentioned this issue Jul 15, 2020
Closed
@hexfusion
Copy link
Contributor

related: #285

@cgwalters
Copy link
Member Author

Upon further reflection, I think we really want to this the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgwalters @hexfusion