Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename operator and router namespaces #52

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Rename operator and router namespaces #52

merged 1 commit into from
Oct 18, 2018

Conversation

ironcladlou
Copy link
Contributor

Rename the following namespaces:

  • openshift-cluster-ingress-operator => openshift-ingress-operator
  • openshift-cluster-ingress-router => openshift-ingress

This is necessary to conform to existing upstream expectations for the location
of router instances (e.g. tests and other installer stuff).

Refactor the RBAC stuff to look a little more consistent.

@ironcladlou
Rename operator and router namespaces
a41ecf4 
Rename the following namespaces:

* openshift-cluster-ingress-operator => openshift-ingress-operator
* openshift-cluster-ingress-router => openshift-ingress

This is necessary to conform to existing upstream expectations for the location
of router instances (e.g. tests and other installer stuff).

Refactor the RBAC stuff to look a little more consistent.
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2018
@ironcladlou
Copy link
Contributor Author

/xref openshift/installer#467

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2018
@ironcladlou
Copy link
Contributor Author

/cc @openshift/sig-network-edge @smarterclayton

@ironcladlou
Copy link
Contributor Author

Tested in a 4.0 AWS cluster with a newly published image:

$ CLUSTER_NAME=dmace make test-integration
hack/test-integration.sh
=== RUN   TestIntegration
=== RUN   TestIntegration/TestDefaultIngress
time="2018-10-17T13:25:03-04:00" level=info msg="testing in namespace ingress-test-jtdrun"
--- PASS: TestIntegration (84.78s)
    --- PASS: TestIntegration/TestDefaultIngress (84.78s)
        test_ingress.go:71: router service openshift-ingress/router-default has external hostname a71d8c685d23111e8a9760251897841d-842485194.us-east-1.elb.amazonaws.com                                        
PASS
ok      github.com/openshift/cluster-ingress-operator/test/integration  84.825s

@ironcladlou ironcladlou mentioned this pull request Oct 17, 2018
Merged
@Miciah
Copy link
Contributor

Miciah commented Oct 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@pravisankar
Copy link

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2018
@pravisankar
Copy link

pravisankar commented Oct 17, 2018 •
edited
Loading

@ironcladlou
config/config.yaml has projectName: cluster-ingress-operator , do we need to rename this? (it says kind: ClusterIngress where is this used?) I think this is expected by operator-sdk but not used else where.

@ironcladlou
Copy link
Contributor Author

@ironcladlou
config/config.yaml has projectName: cluster-ingress-operator , do we need to rename this? (it says kind: ClusterIngress where is this used?) I think this is expected by operator-sdk but not used else where.

This is something related to the operator-sdk, don't remember. I wanted to keep all the go packaging and binary stuff the same.

pravisankar
pravisankar approved these changes Oct 17, 2018
View reviewed changes
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah, pravisankar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pravisankar
Copy link

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2018
ramr
ramr approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@ramr ramr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wking wking mentioned this pull request Oct 17, 2018
Closed
@ironcladlou
Copy link
Contributor Author

/retest

1 similar comment
@ironcladlou
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit abf7bd7 into openshift:master Oct 18, 2018
ironcladlou added a commit to ironcladlou/installer that referenced this pull request Oct 19, 2018
@ironcladlou
Re-disable the cluster-ingress-operator
7a0c740 
Fix the cluster-ingress-operator override to match the
cluster-ingress-operator's new namespace and deployment name[1].

[1] openshift/cluster-ingress-operator#52
@ironcladlou ironcladlou mentioned this pull request Oct 19, 2018
Merged
ironcladlou added a commit to ironcladlou/installer that referenced this pull request Oct 19, 2018
@ironcladlou
Re-disable the cluster-ingress-operator
006929a 
Fix the cluster-ingress-operator override to match the
cluster-ingress-operator's new namespace and deployment name[1].

[1] openshift/cluster-ingress-operator#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravisankar pravisankar pravisankar approved these changes

@ramr ramr ramr approved these changes

@Miciah Miciah Awaiting requested review from Miciah

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@pravisankar pravisankar

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ironcladlou @Miciah @pravisankar @openshift-ci-robot @openshift-bot @ramr @openshift-merge-robot