Skip to content

Commit 269b20e

Browse files
committed
Fix the add-enhancement based on review
1 parent fdf97f2 commit 269b20e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.claude/commands/add-enhancement.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ args:
1111
description: JIRA ticket URL for tracking
1212
---
1313

14-
You are tasked with creating a new OpenShift Enhancement Proposal based on the template at `guidelines/enhancement_template.md`.
14+
You are tasked with creating a new OpenShift Enhancement Proposal based on the template at `guidelines/enhancement_template.md`. You must mirror all required headings from guidelines/enhancement_template.md exactly, even if there is nothing to be added, and in this case the section should be empty.
1515

1616
## Inputs Provided
1717

@@ -35,6 +35,7 @@ Act as an experienced software architect to create a comprehensive enhancement p
3535
- Any specific technical constraints or requirements
3636
- Topology considerations (Hypershift, SNO, MicroShift relevance)
3737
- Whether this proposal adds/changes CRDs, admission and conversion webhooks, aggregated API servers, or finalizers (needed for API Extensions section)
38+
- Ask clarifying questions about telemetry, security, upgrade and downgrade process, rollbacks, dependencies, in case it is not possible to assert these fields.
3839

3940
3. **Generate the Enhancement File**:
4041
- Create the file at `enhancements/{{area}}/{{filename}}.md` where filename is the kebab-case version of the name
@@ -51,7 +52,7 @@ Act as an experienced software architect to create a comprehensive enhancement p
5152
- **Mermaid Diagram**: Add a sequence diagram when applicable to visualize the workflow
5253
- **API Extensions**: Only fill this section if the user confirms the proposal adds/changes CRDs, admission and conversion webhooks, aggregated API servers, or finalizers. Otherwise, add a TODO comment asking the user to complete this section if applicable.
5354
- **Implementation Details/Notes/Constraints**: Provide a high-level overview of the code changes required. Follow the guidance from the template: "While it is useful to go into the details of the code changes required, it is not necessary to show how the code will be rewritten in the enhancement." Keep it as an overview; the developer should fill in the specific implementation details.
54-
- **Metadata**: Fill in creation-date with today's date (2025-10-28), tracking-link with the provided JIRA ticket URL, set other fields to TBD
55+
- **Metadata**: Fill in creation-date with today's date, tracking-link with the provided JIRA ticket URL, set other fields to TBD
5556

5657
4. **Handle Unfilled Sections**: For sections that cannot be filled based on the input:
5758
- Add a clear comment like `<!-- TODO: This section needs to be filled in -->`

0 commit comments

Comments
 (0)