Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable instance types on AWS? #85

Closed
wking opened this issue Oct 2, 2018 · 2 comments
Closed

Configurable instance types on AWS? #85

wking opened this issue Oct 2, 2018 · 2 comments

Comments

@wking
Copy link
Member

wking commented Oct 2, 2018

This could be me just not understanding how this operator is wired up, but it looks like you currently hard-code m4.large here. I'd have expected that information to come from the installer via the cluster config. Am I missing something? Or is this just future work that hasn't happened yet?
@enxebre
Copy link
Member

enxebre commented Oct 3, 2018

thanks @wking yes this is a todo

@trawler trawler mentioned this issue Oct 8, 2018
Closed
@enxebre
Copy link
Member

enxebre commented Oct 29, 2018

Closing this as machines definition lives on the installer now
For reference:
openshift/installer#468
https://github.com/openshift/installer/tree/master/pkg/asset/machines

@enxebre enxebre closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove hard-coding of AWS instance type
2 participants
@wking @enxebre