Skip to content

Commit 8726f79

Browse files
committed
use var from apicfgv1
Signed-off-by: Qi Wang <qiwan@redhat.com>
1 parent 90969fa commit 8726f79

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

pkg/controller/container-runtime-config/container_runtime_config_controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
signature "github.com/containers/image/v5/signature"
1313
ign3types "github.com/coreos/ignition/v2/config/v3_5/types"
1414
apicfgv1 "github.com/openshift/api/config/v1"
15-
apicfgv1alpha1 "github.com/openshift/api/config/v1alpha1"
1615
features "github.com/openshift/api/features"
1716
apioperatorsv1alpha1 "github.com/openshift/api/operator/v1alpha1"
1817
configclientset "github.com/openshift/client-go/config/clientset/versioned"
@@ -1109,7 +1108,7 @@ func getValidScopePolicies(clusterImagePolicies []*apicfgv1.ClusterImagePolicy,
11091108
if len(conflictScopes) > 0 {
11101109
msg := fmt.Sprintf("has conflicting scope(s) %q that equal to or nest inside existing clusterimagepolicy, only policy from clusterimagepolicy scope(s) will be applied", conflictScopes)
11111110
klog.V(2).Info(msg)
1112-
ctrl.syncImagePolicyStatusOnly(namespace, imagePolicy.ObjectMeta.Name, apicfgv1alpha1.ImagePolicyPending, reasonConflictScopes, msg, metav1.ConditionFalse)
1111+
ctrl.syncImagePolicyStatusOnly(namespace, imagePolicy.ObjectMeta.Name, apicfgv1.ImagePolicyPending, reasonConflictScopes, msg, metav1.ConditionFalse)
11131112
}
11141113
}
11151114
}

pkg/controller/container-runtime-config/container_runtime_config_controller_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030

3131
ign3types "github.com/coreos/ignition/v2/config/v3_5/types"
3232
apicfgv1 "github.com/openshift/api/config/v1"
33-
apicfgv1alpha1 "github.com/openshift/api/config/v1alpha1"
3433
features "github.com/openshift/api/features"
3534
mcfgv1 "github.com/openshift/api/machineconfiguration/v1"
3635
apioperatorsv1alpha1 "github.com/openshift/api/operator/v1alpha1"
@@ -217,7 +216,7 @@ func newClusterImagePolicyWithPublicKey(name string, scopes []string, keyData []
217216
imgScopes = append(imgScopes, apicfgv1.ImageScope(scope))
218217
}
219218
return &apicfgv1.ClusterImagePolicy{
220-
TypeMeta: metav1.TypeMeta{APIVersion: apicfgv1alpha1.SchemeGroupVersion.String()},
219+
TypeMeta: metav1.TypeMeta{APIVersion: apicfgv1.SchemeGroupVersion.String()},
221220
ObjectMeta: metav1.ObjectMeta{Name: name, UID: types.UID(utilrand.String(5)), Generation: 1},
222221
Spec: apicfgv1.ClusterImagePolicySpec{
223222
Scopes: imgScopes,
@@ -239,7 +238,7 @@ func newImagePolicyWithPublicKey(name, namespace string, scopes []string, keyDat
239238
imgScopes = append(imgScopes, apicfgv1.ImageScope(scope))
240239
}
241240
return &apicfgv1.ImagePolicy{
242-
TypeMeta: metav1.TypeMeta{APIVersion: apicfgv1alpha1.SchemeGroupVersion.String()},
241+
TypeMeta: metav1.TypeMeta{APIVersion: apicfgv1.SchemeGroupVersion.String()},
243242
ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: namespace, UID: types.UID(utilrand.String(5)), Generation: 1},
244243
Spec: apicfgv1.ImagePolicySpec{
245244
Scopes: imgScopes,

pkg/controller/container-runtime-config/helpers.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"github.com/ghodss/yaml"
2424
"github.com/opencontainers/go-digest"
2525
apicfgv1 "github.com/openshift/api/config/v1"
26-
apicfgv1alpha1 "github.com/openshift/api/config/v1alpha1"
2726
apioperatorsv1alpha1 "github.com/openshift/api/operator/v1alpha1"
2827
"github.com/openshift/runtime-utils/pkg/registries"
2928
runtimeutils "github.com/openshift/runtime-utils/pkg/registries"
@@ -900,13 +899,13 @@ func policyItemFromSpec(policy apicfgv1.Policy) (signature.PolicyRequirement, er
900899
case apicfgv1.IdentityMatchPolicyRemapIdentity:
901900
identity, err := signature.NewPRMRemapIdentity(string(policy.SignedIdentity.PolicyMatchRemapIdentity.Prefix), string(policy.SignedIdentity.PolicyMatchRemapIdentity.SignedPrefix))
902901
if err != nil {
903-
return nil, fmt.Errorf("error getting signedIdentity for %s: %v", apicfgv1alpha1.IdentityMatchPolicyRemapIdentity, err)
902+
return nil, fmt.Errorf("error getting signedIdentity for %s: %v", apicfgv1.IdentityMatchPolicyRemapIdentity, err)
904903
}
905904
signedIdentity = identity
906905
case apicfgv1.IdentityMatchPolicyExactRepository:
907906
identity, err := signature.NewPRMExactRepository(string(policy.SignedIdentity.PolicyMatchExactRepository.Repository))
908907
if err != nil {
909-
return nil, fmt.Errorf("error getting signedIdentity for %s: %v", apicfgv1alpha1.IdentityMatchPolicyExactRepository, err)
908+
return nil, fmt.Errorf("error getting signedIdentity for %s: %v", apicfgv1.IdentityMatchPolicyExactRepository, err)
910909
}
911910
signedIdentity = identity
912911
case apicfgv1.IdentityMatchPolicyMatchRepository:

0 commit comments

Comments
 (0)