Flake TestShouldMakeProgress

[runcom]

The test in $TITLE is racy, I've seen it failing now in #439 - here's the job https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/439/pull-ci-openshift-machine-config-operator-master-unit/1155

The test flake is easily reproducible with:

GOCACHE=off go test -race -v ./cmd/... ./pkg/... ./lib/...

Here's the failing output:

=== RUN   TestShouldMakeProgress
--- FAIL: TestShouldMakeProgress (0.01s)
    node_controller_test.go:171: Action update machineconfigpools has wrong object
        Diff:
         (*v1.MachineConfigPool){TypeMeta:(v1.TypeMeta){Kind:(string) APIVersion:(string)machineconfiguration.openshift.io/v1} ObjectMeta:(v1.ObjectMeta){Name:(string)test-cluster-master GenerateName:(string) Namespace:(string) SelfLink:(string) UID:(types.UID) ResourceVersion:(string) Generation:(int64)0 CreationTimestamp:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} DeletionTimestamp:(*v1.Time)<nil> DeletionGracePeriodSeconds:(*int64)<nil> Labels:(map[string]string)<nil> Annotations:(map[string]string)<nil> OwnerReferences:([]v1.OwnerReference)<nil> Initializers:(*v1.Initializers)<nil> Finalizers:([]string)<nil> ClusterName:(string)} Spec:(v1.MachineConfigPoolSpec){MachineConfigSelector:(*v1.LabelSelector)<nil> MachineSelector:(*v1.LabelSelector){MatchLabels:(map[string]string)map[node-role:master] MatchExpressions:([]v1.LabelSelectorRequirement)<nil>} Paused:(bool)false MaxUnavailable:(*intstr.IntOrString){Type:(intstr.Type)0 IntVal:(int32)1 StrVal:(string)}} Status:(v1.MachineConfigPoolStatus){ObservedGeneration:(int64)0 Configuration:(v1.MachineConfigPoolStatusConfiguration){ObjectReference:(v1.ObjectReference){Kind:(string) Namespace:(string) Name:(string)v1 UID:(types.UID) APIVersion:(string) ResourceVersion:(string) FieldPath:(string)} Source:([]v1.ObjectReference)<nil>} MachineCount:(int32)2 UpdatedMachineCount:(int32)1 ReadyMachineCount:(int32)1 UnavailableMachineCount:(int32)
        
        A: 0 Conditions:([]v1.MachineConfigPoolCondition)[{Type:(v1.MachineConfigPoolConditionType)Updated Status:(v1.ConditionStatus)False LastTransitionTime:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} Reason:(string) Message:(string)} {Type:(v1.MachineConfigPoolConditionType)Updating Status:(v1.ConditionStatus)True LastTransitionTime:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} Reason:(string)All nodes are updating to v1 Message:(string)} {Type:(v1.MachineConfigPoolConditionType)Degraded Status:(v1.ConditionStatus)False LastTransitionTime:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} Reason:(string) Message:(string)}]}}
        
        B: 1 Conditions:([]v1.MachineConfigPoolCondition)[{Type:(v1.MachineConfigPoolConditionType)Updated Status:(v1.ConditionStatus)False LastTransitionTime:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} Reason:(string) Message:(string)} {Type:(v1.MachineConfigPoolConditionType)Updating Status:(v1.ConditionStatus)True LastTransitionTime:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} Reason:(string)All nodes are updating to v1 Message:(string)} {Type:(v1.MachineConfigPoolConditionType)Degraded Status:(v1.ConditionStatus)False LastTransitionTime:(v1.Time){Time:(time.Time){wall:(uint64)0 ext:(int64)0 loc:(*time.Location)<nil>}} Reason:(string) Message:(string)}]}}
        ```

[runcom]

wondering also if this could have the very same root cause as #417