Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API version and schema version tests should be migrated to devfileV2 #3794

Closed
adisky opened this issue Aug 20, 2020 · 3 comments · Fixed by #3920
Closed

API version and schema version tests should be migrated to devfileV2 #3794

adisky opened this issue Aug 20, 2020 · 3 comments · Fixed by #3920
Assignees
Labels
area/refactoring Issues or PRs related to code refactoring

Comments

@adisky
Copy link
Contributor

adisky commented Aug 20, 2020

@adisky
Copy link
Contributor Author

adisky commented Sep 2, 2020

@anandrkskd
Copy link
Contributor

But I see https://github.com/openshift/odo/blob/master/pkg/devfile/parser/context/apiVersion_test.go is not changed/updated in the above PR, is it not required?

@adisky
Copy link
Contributor Author

adisky commented Sep 2, 2020

But I see https://github.com/openshift/odo/blob/master/pkg/devfile/parser/context/apiVersion_test.go is not changed/updated in the above PR, is it not required?

I haven't checked thoroughly, yes these tests should be migrated to devfile v2

@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refactoring Issues or PRs related to code refactoring
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants