Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The odo test command doesn't give enough feedback, by default; odo test exit status #3899

Closed
scottkurz opened this issue Sep 4, 2020 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@scottkurz
Copy link
Contributor

/kind bug

(This is a minor suggestion, not really a true "bug").

What versions of software are you using?

Operating System: Win10, Linux

Output of odo version: 1.2.6

How did you run odo exactly?

A sequence like:

  1. odo create java-openliberty --starter
  2. odo test

Actual behavior

$ odo test

Executing devfile test command for component dd3win10

  • Executing test command "mvn -Dmaven.repo.local=/mvn/repository -Dmicroshed_hostname=localhost -Dmicroshed_http_port=9080 -Dmicroshed_manual_env=true -Dmicroshed_app_context_root=/ failsafe:integration-test", if not runnin

Expected behavior

I'd expect that by default I'd see some indication of whether my tests pass or fail, e.g. the output I get if I do: odo test -v 1. In other words, I'm wondering if the default -v 0 logging should include the log records currently logged at -v 1.

Another idea (which could be combined or separated from this one):

Could odo test propagate an exit status/code, so that success return 0 in $? and failure non-zero?

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 4, 2020
@mik-dass
Copy link
Contributor

mik-dass commented Sep 4, 2020

Currently we have --show-log to get the logs of the test run but the error status/code is not propagated.
You want odo test to show the logs by default without logs and also propagate the exit status/code?

@scottkurz
Copy link
Contributor Author

Currently we have --show-log to get the logs of the test run but the error status/code is not propagated.
You want odo test to show the logs by default without logs and also propagate the exit status/code?

@mik-dass - yes, that was my suggestion. Thanks

@scottkurz
Copy link
Contributor Author

I think odo test already does propagate the exit status... I should've been using:

mvn ... failsafe:integration-test failsafe:verify

not just:

mvn ... failsafe:integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants