Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest images on 3.11 cluster reflects as unsupported on init repo #4220

Closed
prietyc123 opened this issue Nov 15, 2020 · 9 comments
Closed

Latest images on 3.11 cluster reflects as unsupported on init repo #4220

prietyc123 opened this issue Nov 15, 2020 · 9 comments
Assignees
@rnapoles-rh
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@prietyc123
Copy link
Contributor

/kind bug
/kind failing-test

What versions of software are you using?

Operating System:
linux

Output of odo version:
master

How did you run odo exactly?

Running tests on 3.11 cluster travis CI. This is particularly failing on odo-init repo. Details of the issue: redhat-developer/odo-init-image#76

Any logs, error output, etc?

Failure details - https://travis-ci.com/github/openshift/odo-init-image/jobs/432346337
@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test labels Nov 15, 2020
@girishramnani girishramnani added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Nov 19, 2020
@rnapoles-rh
Copy link
Contributor

@dharmit what do we use https://github.com/openshift/odo-init-image for ?

@dharmit
Copy link
Member

dharmit commented Dec 9, 2020

@dharmit what do we use https://github.com/openshift/odo-init-image for ?

I was hoping no one would ever ask me this question because I probably don't completely understand it. But let me take a stab at it.

odo spins up init containers to set up the environment before starting the actual component. And it's the odo init image that's used to do this set up job. We have more info about the tasks in the docs here.

@kadel can you correct me if I am wrong? TBH, I used to dread that someone might ask me this question some day and I would make a fool of myself. 😞

@kadel kadel mentioned this issue Dec 9, 2020
Closed
@kadel
Copy link
Member

kadel commented Dec 9, 2020

We don't know if this is failing just on odo-init-image because travis tests are not running on odo repo for over a month due to a quota change on Travis side :-(

@dharmit
Copy link
Member

dharmit commented Dec 10, 2020

https://github.com/openshift/odo-init-image/blob/master/.travis.yml#L34

@prietyc123
Copy link
Contributor Author

prietyc123 commented Dec 11, 2020 •
edited
Loading

We don't know if this is failing just on odo-init-image because travis tests are not running on odo repo for over a month due to a quota change on Travis side

@kadel I think this is only on odo-init-image because we merged image bumping pr redhat-developer/odo-init-image#71 on 30th July and from that time this was the consistence failure on odo-init-image. However travis tests are not running on odo repo from almost one month. Earlier to that tests were running fine on odo repo. So, this is clearly an issue from odo-init-repo and I have described all my points in the issue redhat-developer/odo-init-image#76

@rnapoles-rh
Copy link
Contributor

rnapoles-rh commented Jan 5, 2021 •
edited
Loading

java is not a supported s2i component on 3.11, however it is supported on 4.x:

Supported components for 4.x:

$ odo catalog list components
Odo Devfile Components:
NAME                 DESCRIPTION                            REGISTRY
java-maven           Upstream Maven and OpenJDK 11          DefaultDevfileRegistry
java-openliberty     Open Liberty microservice in Java      DefaultDevfileRegistry
java-quarkus         Upstream Quarkus with Java+GraalVM     DefaultDevfileRegistry
java-springboot      Spring Boot® using Java                DefaultDevfileRegistry
java-vertx           Upstream Vert.x using Java             DefaultDevfileRegistry
nodejs               Stack with NodeJS 12                   DefaultDevfileRegistry
python               Python Stack with Python 3.7           DefaultDevfileRegistry
python-django        Python3.7 with Django                  DefaultDevfileRegistry

Odo S2I Components:
NAME        PROJECT       TAGS                                                                                SUPPORTED
java        openshift     11,8,latest                                                                         YES
nodejs      openshift     10,12,latest                                                                        YES
dotnet      openshift     2.1,3.1,latest                                                                      NO
golang      openshift     1.11.5,latest                                                                       NO
httpd       openshift     2.4,latest                                                                          NO
nginx       openshift     1.10,1.14,1.16,latest                                                               NO
perl        openshift     5.26,latest                                                                         NO
php         openshift     7.2,7.3,latest                                                                      NO
python      openshift     2.7,3.6,latest                                                                      NO
ruby        openshift     2.4,2.5,2.6,latest                                                                  NO
wildfly     openshift     10.0,10.1,11.0,12.0,13.0,14.0,15.0,16.0,17.0,18.0,19.0,20.0,21.0,8.1,9.0,latest     NO

Supported components for 3.11:

$ odo catalog list components
Odo Devfile Components:
NAME                 DESCRIPTION                            REGISTRY
java-maven           Upstream Maven and OpenJDK 11          DefaultDevfileRegistry
java-openliberty     Open Liberty microservice in Java      DefaultDevfileRegistry
java-quarkus         Upstream Quarkus with Java+GraalVM     DefaultDevfileRegistry
java-springboot      Spring Boot® using Java                DefaultDevfileRegistry
java-vertx           Upstream Vert.x using Java             DefaultDevfileRegistry
nodejs               Stack with NodeJS 12                   DefaultDevfileRegistry
python               Python Stack with Python 3.7           DefaultDevfileRegistry
python-django        Python3.7 with Django                  DefaultDevfileRegistry

Odo S2I Components:
NAME        PROJECT       TAGS                                        SUPPORTED
dotnet      openshift     2.0,latest                                  NO
httpd       openshift     2.4,latest                                  NO
nginx       openshift     1.10,1.12,1.8,latest                        NO
nodejs      openshift     10,6,8,8-RHOAR,latest                       NO
perl        openshift     5.24,5.26,latest                            NO
php         openshift     7.0,7.1,7.2,latest                          NO
python      openshift     2.7,3.5,3.6,latest                          NO
ruby        openshift     2.3,2.4,2.5,latest                          NO
wildfly     openshift     10.0,10.1,11.0,12.0,13.0,8.1,9.0,latest     NO

I ran corresponding test suite locally against 3.11 (minishift) and it fails. Then ran it agains 4.5.2 in PSI and it passes. @prietyc123 I guess that means it is an actual bug on 3.11, not only on odo-init-image, correct?

On 3.11 I can reproduce the java component not found, but is not reproducible on 4.5.2:

Running odo with args [odo component create --s2i java:latest my-component --project gxdmdmawub --context /var/folders/1m/ynw0pw815hq2fmy5zrhktpyh0000gn/T/012513896]
[odo]  ✗  component type "java" not found

These are the results on 3.11 (see 4th failure) for
ginkgo -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo sub component command tests" tests/integration/

    Summarizing 5 Failures:

[Fail] odo sub component command tests when component is in the current directory and --project flag is used [It] creates a local nodejs component and check unsupported warning hasn't occurred 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/integration/component.go:532

[Fail] odo sub component command tests convert s2i to devfile [It] should convert s2i component to devfile component successfully 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/helper/helper_run.go:34

[Fail] odo sub component command tests Creating component [It] binary component should not fail when --context is not set 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/helper/helper_run.go:34

[Fail] odo sub component command tests when component is in the current directory and --project flag is used [It] creates a local java component and check unsupported warning hasn't occurred** 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/helper/helper_run.go:34

[Fail] odo sub component command tests Creating component [It] binary component is valid if path is relative and includes ../ 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/helper/helper_run.go:34

Ran 46 of 175 Specs in 658.195 seconds
FAIL! -- 41 Passed | 5 Failed | 0 Pending | 129 Skipped

This are the results on 4.5.2 (PSI) for same test suite:

    Summarizing 2 Failures:

[Fail] odo sub component command tests Creating component [It] binary component should not fail when --context is not set 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/helper/helper_run.go:34

[Fail] odo sub component command tests Creating component [It] binary component is valid if path is relative and includes ../ 
/Users/rnapoles@ca.ibm.com/go/src/github.com/rnapoles-rh/odo/tests/helper/helper_run.go:34

Ran 46 of 175 Specs in 765.773 seconds
FAIL! -- 44 Passed | 2 Failed | 0 Pending | 129 Skipped

Based on the above the failure is expected. I will close if agreed. In such case I will update the test script to skip it for 3.11.

@kadel
Copy link
Member

kadel commented Jan 6, 2021

The problem is actually in the test setup.
The tests were failing only on odo-init-image repo and not on odo repo because travis.yaml in odo-init-image repo was missing make configure-supported-311-is which adds the newer supported image to 3.11 clusters.

This PR is fixing it redhat-developer/odo-init-image#77

@rnapoles-rh rnapoles-rh mentioned this issue Jan 6, 2021
Merged
@rnapoles-rh
Copy link
Contributor

@kadel then I will close this one once redhat-developer/odo-init-image#77 is closed

@rnapoles-rh
Copy link
Contributor

closing as redhat-developer/odo-init-image#77 fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnapoles-rh rnapoles-rh

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kadel @dharmit @girishramnani @openshift-ci-robot @prietyc123 @rnapoles-rh