Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo requires the 'master' branch #4257

Closed
goern opened this issue Nov 25, 2020 · 3 comments · Fixed by #4260
Closed

odo requires the 'master' branch #4257

goern opened this issue Nov 25, 2020 · 3 comments · Fixed by #4260
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@goern
Copy link
Member

goern commented Nov 25, 2020

/kind bug

What versions of software are you using?

Operating System: Fedora 32

Output of odo version: odo v2.0.1 (a9fff7d)

How did you run odo exactly?

odo create --devfile https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml --starter -v 5

Actual behavior

I1125 11:48:09.678897  303618 util.go:730] HTTPGetRequest: https://raw.githubusercontent.com/openshift/odo/master/build/VERSION
I1125 11:48:09.678974  303618 util.go:751] Response will be cached in /tmp/odohttpcache for 1h0m0s
I1125 11:48:09.679037  303618 util.go:764] Cached response used.
I1125 11:48:09.821245  303618 util.go:425] path .odo/config.yaml doesn't exist, skipping it
I1125 11:48:09.821305  303618 util.go:425] path .odo/env/env.yaml doesn't exist, skipping it
I1125 11:48:09.821343  303618 util.go:425] path devfile.yaml doesn't exist, skipping it
I1125 11:48:09.821462  303618 util.go:425] path devfile.yaml doesn't exist, skipping it
I1125 11:48:09.821496  303618 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml
I1125 11:48:09.838847  303618 util.go:425] path devfile.yaml doesn't exist, skipping it
I1125 11:48:09.838934  303618 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml
I1125 11:48:09.851258  303618 util.go:425] path devfile.yaml doesn't exist, skipping it
Validation
I1125 11:48:09.851294  303618 util.go:425] path devfile.yaml doesn't exist, skipping it
 •  Creating a devfile component from devfile path: https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml  ...
 ✓  Creating a devfile component from devfile path: https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml [45712ns]
 •  Validating devfile component  ...
I1125 11:48:09.851378  303618 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml
 ✓  Validating devfile component [167059ns]
I1125 11:48:09.851549  303618 util.go:730] HTTPGetRequest: https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml
I1125 11:48:09.978051  303618 content.go:34] converted devfile YAML to JSON
I1125 11:48:09.978107  303618 apiVersion.go:50] devfile apiVersion: '2.0.0'
I1125 11:48:09.978115  303618 helper.go:36] devfile apiVersion '2.0.0' is supported in odo
I1125 11:48:09.983099  303618 schema.go:47] validated devfile schema
I1125 11:48:09.983466  303618 validate.go:43] Successfully validated devfile sections
I1125 11:48:09.983476  303618 validate.go:43] Successfully validated devfile sections
I1125 11:48:09.983483  303618 validate.go:43] Successfully validated devfile sections
I1125 11:48:09.983486  303618 validate.go:43] Successfully validated devfile sections
I1125 11:48:09.983529  303618 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml

Starter Project
 •  Downloading starter project thoth-odo-example from https://github.com/goern/thoth-odo-example  ...
 ✗  Downloading starter project thoth-odo-example from https://github.com/goern/thoth-odo-example [382ms]
 ✗  couldn't find remote ref "refs/heads/master"

Expected behavior

I1125 11:49:19.892935  303743 util.go:730] HTTPGetRequest: https://raw.githubusercontent.com/openshift/odo/master/build/VERSION
I1125 11:49:19.893515  303743 util.go:751] Response will be cached in /tmp/odohttpcache for 1h0m0s
I1125 11:49:19.894018  303743 util.go:764] Cached response used.
I1125 11:49:20.037106  303743 util.go:425] path .odo/config.yaml doesn't exist, skipping it
I1125 11:49:20.037127  303743 util.go:425] path .odo/env/env.yaml doesn't exist, skipping it
I1125 11:49:20.037139  303743 util.go:425] path devfile.yaml doesn't exist, skipping it
I1125 11:49:20.037179  303743 util.go:425] path devfile.yaml doesn't exist, skipping it
I1125 11:49:20.037190  303743 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml
I1125 11:49:20.043378  303743 util.go:425] path devfile.yaml doesn't exist, skipping it
I1125 11:49:20.043403  303743 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml
I1125 11:49:20.050274  303743 util.go:425] path devfile.yaml doesn't exist, skipping it
Validation
I1125 11:49:20.050300  303743 util.go:425] path devfile.yaml doesn't exist, skipping it
 •  Creating a devfile component from devfile path: https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml  ...
 ✓  Creating a devfile component from devfile path: https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml [37959ns]
 •  Validating devfile component  ...
I1125 11:49:20.050369  303743 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml
 ✓  Validating devfile component [118740ns]
I1125 11:49:20.050492  303743 util.go:730] HTTPGetRequest: https://raw.githubusercontent.com/goern/thoth-odo-example/main/devfile.yaml
I1125 11:49:20.246928  303743 content.go:34] converted devfile YAML to JSON
I1125 11:49:20.247032  303743 apiVersion.go:50] devfile apiVersion: '2.0.0'
I1125 11:49:20.247046  303743 helper.go:36] devfile apiVersion '2.0.0' is supported in odo
I1125 11:49:20.259034  303743 schema.go:47] validated devfile schema
I1125 11:49:20.259955  303743 validate.go:43] Successfully validated devfile sections
I1125 11:49:20.259979  303743 validate.go:43] Successfully validated devfile sections
I1125 11:49:20.259991  303743 validate.go:43] Successfully validated devfile sections
I1125 11:49:20.259998  303743 validate.go:43] Successfully validated devfile sections
I1125 11:49:20.260084  303743 preference.go:209] The path for preference file is /home/goern/.odo/preference.yaml

Starter Project
 •  Downloading starter project thoth-odo-example from https://github.com/goern/thoth-odo-example  ...
 ✓  Downloading starter project thoth-odo-example from https://github.com/goern/thoth-odo-example [861ms]

Please use `odo push` command to create the component with source deployed
I1125 11:49:21.122317  303743 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 25, 2020
@adisky
Copy link
Contributor

adisky commented Nov 26, 2020

odo takes default branch as master, currently specifying branch name is not supported by odo.
however it should support main as default branch too as many projects are now using main as default branch

@adisky adisky self-assigned this Nov 26, 2020
@goern
Copy link
Member Author

goern commented Nov 26, 2020

actually odo should be able to checkout out any branch, isn't the devfile format supporting that?

@adisky
Copy link
Contributor

adisky commented Nov 26, 2020

yes, it should support checkout from any branch. Devfile format supports it, its just not implemented in odo.

starterProjects:
  - name: thoth-odo-example
    git:
      remotes:
        origin: https://github.com/goern/thoth-odo-example
      checkoutFrom:
        remote: origin
        revision: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants