You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per this comment originally, if possible lets match DataService API when we create new services to abstract away logic:
// example:DataService.get(resource,name,context,opts)// current:BindingService.bindService(context,name,application)// ideal:BindingService.bindService(name,context,opts)// where application prob could be part of context or opts, depending on its internal usage
I'm a fan of these services to keep controllers, directives, etc clean, just want to make sure we maintain consistency.
Hey @benjaminapetersen I think this is reasonable, and we can watch for it in code reviews. The signature of these particular methods have changed since the issue was opened, so I'm going to call this "closed."
Per this comment originally, if possible lets match
DataService
API when we create new services to abstract away logic:I'm a fan of these services to keep controllers, directives, etc clean, just want to make sure we maintain consistency.
@jwforres @jeff-phillips-18
The text was updated successfully, but these errors were encountered: