Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure derivative service of DataService match function signatures when possible #96

Closed
benjaminapetersen opened this issue Jun 7, 2017 · 2 comments

Comments

@benjaminapetersen
Copy link
Contributor

Per this comment originally, if possible lets match DataService API when we create new services to abstract away logic:

// example:
DataService.get(resource, name, context, opts)
// current:
BindingService.bindService(context, name, application)
// ideal:
BindingService.bindService(name, context, opts) // where application prob could be part of context or opts, depending on its internal usage 

I'm a fan of these services to keep controllers, directives, etc clean, just want to make sure we maintain consistency.

@jwforres @jeff-phillips-18

@spadgett
Copy link
Member

spadgett commented Aug 1, 2017

Hey @benjaminapetersen I think this is reasonable, and we can watch for it in code reviews. The signature of these particular methods have changed since the issue was opened, so I'm going to call this "closed."

@spadgett spadgett closed this as completed Aug 1, 2017
@benjaminapetersen
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants